Commit eb3de6a4 authored by Chuck Lever's avatar Chuck Lever

svcrdma: Use parsed chunk lists to derive the inv_rkey

Refactor: Don't duplicate header decoding smarts here. Instead, use
the new parsed chunk lists.
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
parent 78147ca8
...@@ -586,60 +586,53 @@ static bool xdr_check_reply_chunk(struct svc_rdma_recv_ctxt *rctxt) ...@@ -586,60 +586,53 @@ static bool xdr_check_reply_chunk(struct svc_rdma_recv_ctxt *rctxt)
* *
* If there is exactly one distinct R_key in the received transport * If there is exactly one distinct R_key in the received transport
* header, set rc_inv_rkey to that R_key. Otherwise, set it to zero. * header, set rc_inv_rkey to that R_key. Otherwise, set it to zero.
*
* Perform this operation while the received transport header is
* still in the CPU cache.
*/ */
static void svc_rdma_get_inv_rkey(struct svcxprt_rdma *rdma, static void svc_rdma_get_inv_rkey(struct svcxprt_rdma *rdma,
struct svc_rdma_recv_ctxt *ctxt) struct svc_rdma_recv_ctxt *ctxt)
{ {
__be32 inv_rkey, *p; struct svc_rdma_segment *segment;
u32 i, segcount; struct svc_rdma_chunk *chunk;
u32 inv_rkey;
ctxt->rc_inv_rkey = 0; ctxt->rc_inv_rkey = 0;
if (!rdma->sc_snd_w_inv) if (!rdma->sc_snd_w_inv)
return; return;
inv_rkey = xdr_zero; inv_rkey = 0;
p = ctxt->rc_recv_buf; pcl_for_each_chunk(chunk, &ctxt->rc_call_pcl) {
p += rpcrdma_fixed_maxsz; pcl_for_each_segment(segment, chunk) {
if (inv_rkey == 0)
/* Read list */ inv_rkey = segment->rs_handle;
while (xdr_item_is_present(p++)) { else if (inv_rkey != segment->rs_handle)
p++; /* position */ return;
if (inv_rkey == xdr_zero) }
inv_rkey = *p;
else if (inv_rkey != *p)
return;
p += 4;
} }
pcl_for_each_chunk(chunk, &ctxt->rc_read_pcl) {
/* Write list */ pcl_for_each_segment(segment, chunk) {
while (xdr_item_is_present(p++)) { if (inv_rkey == 0)
segcount = be32_to_cpup(p++); inv_rkey = segment->rs_handle;
for (i = 0; i < segcount; i++) { else if (inv_rkey != segment->rs_handle)
if (inv_rkey == xdr_zero)
inv_rkey = *p;
else if (inv_rkey != *p)
return; return;
p += 4;
} }
} }
pcl_for_each_chunk(chunk, &ctxt->rc_write_pcl) {
/* Reply chunk */ pcl_for_each_segment(segment, chunk) {
if (xdr_item_is_present(p++)) { if (inv_rkey == 0)
segcount = be32_to_cpup(p++); inv_rkey = segment->rs_handle;
for (i = 0; i < segcount; i++) { else if (inv_rkey != segment->rs_handle)
if (inv_rkey == xdr_zero)
inv_rkey = *p;
else if (inv_rkey != *p)
return; return;
p += 4;
} }
} }
pcl_for_each_chunk(chunk, &ctxt->rc_reply_pcl) {
ctxt->rc_inv_rkey = be32_to_cpu(inv_rkey); pcl_for_each_segment(segment, chunk) {
if (inv_rkey == 0)
inv_rkey = segment->rs_handle;
else if (inv_rkey != segment->rs_handle)
return;
}
}
ctxt->rc_inv_rkey = inv_rkey;
} }
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment