Commit eb881eba authored by Jiri Slaby (SUSE)'s avatar Jiri Slaby (SUSE) Committed by Greg Kroah-Hartman

use clamp() for counts in csi_?() handlers

The count to process is supposed to be between 1 and vc->vc_cols -
vc->state.x (or rows and .y). clamp() can be used exactly for this,
instead of ifs and min().
Signed-off-by: default avatar"Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Tested-by: Helge Deller <deller@gmx.de> # parisc STI console
Link: https://lore.kernel.org/r/20240122110401.7289-14-jirislaby@kernel.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fe4f6beb
...@@ -1574,12 +1574,7 @@ static void csi_K(struct vc_data *vc, int vpar) ...@@ -1574,12 +1574,7 @@ static void csi_K(struct vc_data *vc, int vpar)
/* erase the following vpar positions */ /* erase the following vpar positions */
static void csi_X(struct vc_data *vc, unsigned int vpar) static void csi_X(struct vc_data *vc, unsigned int vpar)
{ /* not vt100? */ { /* not vt100? */
unsigned int count; unsigned int count = clamp(vpar, 1, vc->vc_cols - vc->state.x);
if (!vpar)
vpar++;
count = min(vpar, vc->vc_cols - vc->state.x);
vc_uniscr_clear_line(vc, vc->state.x, count); vc_uniscr_clear_line(vc, vc->state.x, count);
scr_memsetw((unsigned short *)vc->vc_pos, vc->vc_video_erase_char, 2 * count); scr_memsetw((unsigned short *)vc->vc_pos, vc->vc_video_erase_char, 2 * count);
...@@ -2010,20 +2005,14 @@ static void setterm_command(struct vc_data *vc) ...@@ -2010,20 +2005,14 @@ static void setterm_command(struct vc_data *vc)
/* console_lock is held */ /* console_lock is held */
static void csi_at(struct vc_data *vc, unsigned int nr) static void csi_at(struct vc_data *vc, unsigned int nr)
{ {
if (nr > vc->vc_cols - vc->state.x) nr = clamp(nr, 1, vc->vc_cols - vc->state.x);
nr = vc->vc_cols - vc->state.x;
else if (!nr)
nr = 1;
insert_char(vc, nr); insert_char(vc, nr);
} }
/* console_lock is held */ /* console_lock is held */
static void csi_L(struct vc_data *vc, unsigned int nr) static void csi_L(struct vc_data *vc, unsigned int nr)
{ {
if (nr > vc->vc_rows - vc->state.y) nr = clamp(nr, 1, vc->vc_rows - vc->state.y);
nr = vc->vc_rows - vc->state.y;
else if (!nr)
nr = 1;
con_scroll(vc, vc->state.y, vc->vc_bottom, SM_DOWN, nr); con_scroll(vc, vc->state.y, vc->vc_bottom, SM_DOWN, nr);
vc->vc_need_wrap = 0; vc->vc_need_wrap = 0;
} }
...@@ -2031,20 +2020,14 @@ static void csi_L(struct vc_data *vc, unsigned int nr) ...@@ -2031,20 +2020,14 @@ static void csi_L(struct vc_data *vc, unsigned int nr)
/* console_lock is held */ /* console_lock is held */
static void csi_P(struct vc_data *vc, unsigned int nr) static void csi_P(struct vc_data *vc, unsigned int nr)
{ {
if (nr > vc->vc_cols - vc->state.x) nr = clamp(nr, 1, vc->vc_cols - vc->state.x);
nr = vc->vc_cols - vc->state.x;
else if (!nr)
nr = 1;
delete_char(vc, nr); delete_char(vc, nr);
} }
/* console_lock is held */ /* console_lock is held */
static void csi_M(struct vc_data *vc, unsigned int nr) static void csi_M(struct vc_data *vc, unsigned int nr)
{ {
if (nr > vc->vc_rows - vc->state.y) nr = clamp(nr, 1, vc->vc_rows - vc->state.y);
nr = vc->vc_rows - vc->state.y;
else if (!nr)
nr=1;
con_scroll(vc, vc->state.y, vc->vc_bottom, SM_UP, nr); con_scroll(vc, vc->state.y, vc->vc_bottom, SM_UP, nr);
vc->vc_need_wrap = 0; vc->vc_need_wrap = 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment