Commit ecc3f3ed authored by Nicholas Mc Guire's avatar Nicholas Mc Guire Committed by Nicholas Bellinger

ib_srpt: wait_for_completion_timeout does not return negative status

This patch changes srpt_close_session() to properly use an unsigned long
for wait_for_completion_timeout()'s return value, and to update WARN_ON()
to only trigger for a zero return.
Signed-off-by: default avatarNicholas Mc Guire <der.herr@hofr.at>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 5cdf5a87
...@@ -3518,7 +3518,7 @@ static void srpt_close_session(struct se_session *se_sess) ...@@ -3518,7 +3518,7 @@ static void srpt_close_session(struct se_session *se_sess)
DECLARE_COMPLETION_ONSTACK(release_done); DECLARE_COMPLETION_ONSTACK(release_done);
struct srpt_rdma_ch *ch; struct srpt_rdma_ch *ch;
struct srpt_device *sdev; struct srpt_device *sdev;
int res; unsigned long res;
ch = se_sess->fabric_sess_ptr; ch = se_sess->fabric_sess_ptr;
WARN_ON(ch->sess != se_sess); WARN_ON(ch->sess != se_sess);
...@@ -3533,7 +3533,7 @@ static void srpt_close_session(struct se_session *se_sess) ...@@ -3533,7 +3533,7 @@ static void srpt_close_session(struct se_session *se_sess)
spin_unlock_irq(&sdev->spinlock); spin_unlock_irq(&sdev->spinlock);
res = wait_for_completion_timeout(&release_done, 60 * HZ); res = wait_for_completion_timeout(&release_done, 60 * HZ);
WARN_ON(res <= 0); WARN_ON(res == 0);
} }
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment