Commit ecf6dedd authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

USB: usbip: clean up mixed use of _irq() and _irqsave()

It generally doesn't make sense to use _irq() and _irqsave() in the same
function because either some of the callers have disabled IRQs or they
haven't.  In this case, the v_recv_cmd_submit() appears to always be
called with IRQs enabled so the code works fine.  That means I could
convert it to either _irq() or _irqsave() but I chose to use _irqsave()
because it's more conservative and easier to review.
Reviewed-by: default avatarShuah Khan <skhan@linuxfoundation.org>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/Yo4gqLPtHO6XKMLn@kiliSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent df22ecc4
...@@ -104,18 +104,18 @@ static int v_recv_cmd_submit(struct vudc *udc, ...@@ -104,18 +104,18 @@ static int v_recv_cmd_submit(struct vudc *udc,
if (pdu->base.direction == USBIP_DIR_IN) if (pdu->base.direction == USBIP_DIR_IN)
address |= USB_DIR_IN; address |= USB_DIR_IN;
spin_lock_irq(&udc->lock); spin_lock_irqsave(&udc->lock, flags);
urb_p->ep = vudc_find_endpoint(udc, address); urb_p->ep = vudc_find_endpoint(udc, address);
if (!urb_p->ep) { if (!urb_p->ep) {
/* we don't know the type, there may be isoc data! */ /* we don't know the type, there may be isoc data! */
dev_err(&udc->pdev->dev, "request to nonexistent endpoint"); dev_err(&udc->pdev->dev, "request to nonexistent endpoint");
spin_unlock_irq(&udc->lock); spin_unlock_irqrestore(&udc->lock, flags);
usbip_event_add(&udc->ud, VUDC_EVENT_ERROR_TCP); usbip_event_add(&udc->ud, VUDC_EVENT_ERROR_TCP);
ret = -EPIPE; ret = -EPIPE;
goto free_urbp; goto free_urbp;
} }
urb_p->type = urb_p->ep->type; urb_p->type = urb_p->ep->type;
spin_unlock_irq(&udc->lock); spin_unlock_irqrestore(&udc->lock, flags);
urb_p->new = 1; urb_p->new = 1;
urb_p->seqnum = pdu->base.seqnum; urb_p->seqnum = pdu->base.seqnum;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment