Commit ed43fbac authored by Leon Romanovsky's avatar Leon Romanovsky Committed by David S. Miller

devlink: Clear whole devlink_flash_notify struct

The { 0 } doesn't clear all fields in the struct, but tells to the
compiler to set all fields to zero and doesn't touch any sub-fields
if they exists.

The {} is an empty initialiser that instructs to fully initialize whole
struct including sub-fields, which is error-prone for future
devlink_flash_notify extensions.

Fixes: 6700acc5 ("devlink: collect flash notify params into a struct")
Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 11a861d7
...@@ -4169,7 +4169,7 @@ static void __devlink_flash_update_notify(struct devlink *devlink, ...@@ -4169,7 +4169,7 @@ static void __devlink_flash_update_notify(struct devlink *devlink,
static void devlink_flash_update_begin_notify(struct devlink *devlink) static void devlink_flash_update_begin_notify(struct devlink *devlink)
{ {
struct devlink_flash_notify params = { 0 }; struct devlink_flash_notify params = {};
__devlink_flash_update_notify(devlink, __devlink_flash_update_notify(devlink,
DEVLINK_CMD_FLASH_UPDATE, DEVLINK_CMD_FLASH_UPDATE,
...@@ -4178,7 +4178,7 @@ static void devlink_flash_update_begin_notify(struct devlink *devlink) ...@@ -4178,7 +4178,7 @@ static void devlink_flash_update_begin_notify(struct devlink *devlink)
static void devlink_flash_update_end_notify(struct devlink *devlink) static void devlink_flash_update_end_notify(struct devlink *devlink)
{ {
struct devlink_flash_notify params = { 0 }; struct devlink_flash_notify params = {};
__devlink_flash_update_notify(devlink, __devlink_flash_update_notify(devlink,
DEVLINK_CMD_FLASH_UPDATE_END, DEVLINK_CMD_FLASH_UPDATE_END,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment