Commit ee2bd216 authored by Linus Torvalds's avatar Linus Torvalds

ASoC: lpass-platform: fix uninitialized variable

In commit 022d00ee ("ASoC: lpass-platform: Fix broken pcm data
usage") the stream specific information initialization was broken, with
the dma channel information not being initialized if there was no
alloc_dma_channel() helper function.

Before that, the DMA channel number was implicitly initialized to zero
because the backing store was allocated with devm_kzalloc().  When the
init code was rewritten, that implicit initialization was lost, and gcc
rightfully complains about an uninitialized variable being used.

Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Mark Brown <broonie@kernel.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent f5c9f9c7
...@@ -75,6 +75,7 @@ static int lpass_platform_pcmops_open(struct snd_pcm_substream *substream) ...@@ -75,6 +75,7 @@ static int lpass_platform_pcmops_open(struct snd_pcm_substream *substream)
data->i2s_port = cpu_dai->driver->id; data->i2s_port = cpu_dai->driver->id;
runtime->private_data = data; runtime->private_data = data;
dma_ch = 0;
if (v->alloc_dma_channel) if (v->alloc_dma_channel)
dma_ch = v->alloc_dma_channel(drvdata, dir); dma_ch = v->alloc_dma_channel(drvdata, dir);
if (dma_ch < 0) if (dma_ch < 0)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment