Commit ee7bf1c3 authored by Neil Brown's avatar Neil Brown Committed by Linus Torvalds

[PATCH] knfsd: nfsd4: encode_dirent: superfluous local variables

The local variables bmval0 and bmval1 turn out not to really help much.
Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: default avatarNeil Brown <neilb@cse.unsw.edu.au>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent ee9eabb5
...@@ -1779,7 +1779,6 @@ nfsd4_encode_dirent(struct readdir_cd *ccd, const char *name, int namlen, ...@@ -1779,7 +1779,6 @@ nfsd4_encode_dirent(struct readdir_cd *ccd, const char *name, int namlen,
u32 *attrlenp; u32 *attrlenp;
struct dentry *dentry; struct dentry *dentry;
struct svc_export *exp = cd->rd_fhp->fh_export; struct svc_export *exp = cd->rd_fhp->fh_export;
u32 bmval0, bmval1;
int nfserr = 0; int nfserr = 0;
/* In nfsv4, "." and ".." never make it onto the wire.. */ /* In nfsv4, "." and ".." never make it onto the wire.. */
...@@ -1803,9 +1802,6 @@ nfsd4_encode_dirent(struct readdir_cd *ccd, const char *name, int namlen, ...@@ -1803,9 +1802,6 @@ nfsd4_encode_dirent(struct readdir_cd *ccd, const char *name, int namlen,
/* /*
* Now we come to the ugly part: writing the fattr for this entry. * Now we come to the ugly part: writing the fattr for this entry.
*/ */
bmval0 = cd->rd_bmval[0];
bmval1 = cd->rd_bmval[1];
dentry = lookup_one_len(name, cd->rd_fhp->fh_dentry, namlen); dentry = lookup_one_len(name, cd->rd_fhp->fh_dentry, namlen);
if (IS_ERR(dentry)) { if (IS_ERR(dentry)) {
nfserr = nfserrno(PTR_ERR(dentry)); nfserr = nfserrno(PTR_ERR(dentry));
...@@ -1852,19 +1848,16 @@ nfsd4_encode_dirent(struct readdir_cd *ccd, const char *name, int namlen, ...@@ -1852,19 +1848,16 @@ nfsd4_encode_dirent(struct readdir_cd *ccd, const char *name, int namlen,
* then in accordance with the spec, we fail the * then in accordance with the spec, we fail the
* entire READDIR operation(!) * entire READDIR operation(!)
*/ */
if (!(bmval0 & FATTR4_WORD0_RDATTR_ERROR)) { if (!(cd->rd_bmval[0] & FATTR4_WORD0_RDATTR_ERROR)) {
cd->common.err = nfserr; cd->common.err = nfserr;
return -EINVAL; return -EINVAL;
} }
bmval0 = FATTR4_WORD0_RDATTR_ERROR;
bmval1 = 0;
if (buflen < 6) if (buflen < 6)
goto nospc; goto nospc;
*p++ = htonl(2); *p++ = htonl(2);
*p++ = htonl(bmval0); *p++ = htonl(FATTR4_WORD0_RDATTR_ERROR); /* bmval0 */
*p++ = htonl(bmval1); *p++ = htonl(0); /* bmval1 */
attrlenp = p++; attrlenp = p++;
*p++ = nfserr; /* no htonl */ *p++ = nfserr; /* no htonl */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment