Commit ee896ee8 authored by Vincent Whitchurch's avatar Vincent Whitchurch Committed by Steven Rostedt (VMware)

tracing: Remove outdated comment in stack handling

This comment describes the behaviour before commit 2a820bf7
("tracing: Use percpu stack trace buffer more intelligently").  Since
that commit, interrupts and NMIs do use the per-cpu stacks so the
comment is no longer correct.  Remove it.

(Note that the FTRACE_STACK_SIZE mentioned in the comment has never
existed, it probably should have said FTRACE_STACK_ENTRIES.)

Link: https://lkml.kernel.org/r/20200727092840.18659-1-vincent.whitchurch@axis.comSigned-off-by: default avatarVincent Whitchurch <vincent.whitchurch@axis.com>
Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
parent c5f51572
...@@ -2930,12 +2930,6 @@ static void __ftrace_trace_stack(struct trace_buffer *buffer, ...@@ -2930,12 +2930,6 @@ static void __ftrace_trace_stack(struct trace_buffer *buffer,
skip++; skip++;
#endif #endif
/*
* Since events can happen in NMIs there's no safe way to
* use the per cpu ftrace_stacks. We reserve it and if an interrupt
* or NMI comes in, it will just have to use the default
* FTRACE_STACK_SIZE.
*/
preempt_disable_notrace(); preempt_disable_notrace();
stackidx = __this_cpu_inc_return(ftrace_stack_reserve) - 1; stackidx = __this_cpu_inc_return(ftrace_stack_reserve) - 1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment