Commit ee94d523 authored by Tejun Heo's avatar Tejun Heo Committed by Linus Torvalds

posix-timers: convert to idr_alloc()

Convert to the much saner new idr interface.
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 0e9c3be2
...@@ -552,24 +552,22 @@ SYSCALL_DEFINE3(timer_create, const clockid_t, which_clock, ...@@ -552,24 +552,22 @@ SYSCALL_DEFINE3(timer_create, const clockid_t, which_clock,
return -EAGAIN; return -EAGAIN;
spin_lock_init(&new_timer->it_lock); spin_lock_init(&new_timer->it_lock);
retry:
if (unlikely(!idr_pre_get(&posix_timers_id, GFP_KERNEL))) { idr_preload(GFP_KERNEL);
error = -EAGAIN;
goto out;
}
spin_lock_irq(&idr_lock); spin_lock_irq(&idr_lock);
error = idr_get_new(&posix_timers_id, new_timer, &new_timer_id); error = idr_alloc(&posix_timers_id, new_timer, 0, 0, GFP_NOWAIT);
spin_unlock_irq(&idr_lock); spin_unlock_irq(&idr_lock);
if (error) { idr_preload_end();
if (error == -EAGAIN) if (error < 0) {
goto retry;
/* /*
* Weird looking, but we return EAGAIN if the IDR is * Weird looking, but we return EAGAIN if the IDR is
* full (proper POSIX return value for this) * full (proper POSIX return value for this)
*/ */
error = -EAGAIN; if (error == -ENOSPC)
error = -EAGAIN;
goto out; goto out;
} }
new_timer_id = error;
it_id_set = IT_ID_SET; it_id_set = IT_ID_SET;
new_timer->it_id = (timer_t) new_timer_id; new_timer->it_id = (timer_t) new_timer_id;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment