Commit eec73c2e authored by Colin Ian King's avatar Colin Ian King Committed by Martin K. Petersen

scsi: qla4xxx: Remove redundant check on drvr_wait

The check for a non-zero drvr_wait is redundant as the same check is performed
earlier in the outer while loop, the inner check will always be true if we
reached this point inside the while loop.  Remove the redundant if check.

Detected by cppcheck:
(warning) Identical inner 'if' condition is always true.
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Acked-by: default avatarManish Rangankar <Manish.Rangankar@cavium.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 9fe278f4
...@@ -766,12 +766,10 @@ int ql4xxx_lock_drvr_wait(struct scsi_qla_host *a) ...@@ -766,12 +766,10 @@ int ql4xxx_lock_drvr_wait(struct scsi_qla_host *a)
while (drvr_wait) { while (drvr_wait) {
if (ql4xxx_lock_drvr(a) == 0) { if (ql4xxx_lock_drvr(a) == 0) {
ssleep(QL4_LOCK_DRVR_SLEEP); ssleep(QL4_LOCK_DRVR_SLEEP);
if (drvr_wait) { DEBUG2(printk("scsi%ld: %s: Waiting for "
DEBUG2(printk("scsi%ld: %s: Waiting for " "Global Init Semaphore(%d)...\n",
"Global Init Semaphore(%d)...\n", a->host_no,
a->host_no, __func__, drvr_wait));
__func__, drvr_wait));
}
drvr_wait -= QL4_LOCK_DRVR_SLEEP; drvr_wait -= QL4_LOCK_DRVR_SLEEP;
} else { } else {
DEBUG2(printk("scsi%ld: %s: Global Init Semaphore " DEBUG2(printk("scsi%ld: %s: Global Init Semaphore "
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment