Commit ef43c308 authored by Ilpo Järvinen's avatar Ilpo Järvinen Committed by Shuah Khan

selftests/resctrl: Reduce failures due to outliers in MBA/MBM tests

The initial value of 5% chosen for the maximum allowed percentage
difference between resctrl mbm value and IMC mbm value in

commit 06bd03a5 ("selftests/resctrl: Fix MBA/MBM results reporting
       format") was "randomly chosen value" (as admitted by the changelog).

When running tests in our lab across a large number platforms, 5%
difference upper bound for success seems a bit on the low side for the
MBA and MBM tests. Some platforms produce outliers that are slightly
above that, typically 6-7%, which leads MBA/MBM test frequently
failing.

Replace the "randomly chosen value" with a success bound that is based
on those measurements across large number of platforms by relaxing the
MBA/MBM success bound to 8%. The relaxed bound removes the failures due
the frequent outliers.

Fixed commit description style error during merge:
Shuah Khan <skhan@linuxfoundation.org>

Fixes: 06bd03a5 ("selftests/resctrl: Fix MBA/MBM results reporting format")
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tested-by: default avatarShaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Reviewed-by: default avatarReinette Chatre <reinette.chatre@intel.com>
Reviewed-by: default avatarShaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent 06035f01
...@@ -12,7 +12,7 @@ ...@@ -12,7 +12,7 @@
#define RESULT_FILE_NAME "result_mba" #define RESULT_FILE_NAME "result_mba"
#define NUM_OF_RUNS 5 #define NUM_OF_RUNS 5
#define MAX_DIFF_PERCENT 5 #define MAX_DIFF_PERCENT 8
#define ALLOCATION_MAX 100 #define ALLOCATION_MAX 100
#define ALLOCATION_MIN 10 #define ALLOCATION_MIN 10
#define ALLOCATION_STEP 10 #define ALLOCATION_STEP 10
......
...@@ -11,7 +11,7 @@ ...@@ -11,7 +11,7 @@
#include "resctrl.h" #include "resctrl.h"
#define RESULT_FILE_NAME "result_mbm" #define RESULT_FILE_NAME "result_mbm"
#define MAX_DIFF_PERCENT 5 #define MAX_DIFF_PERCENT 8
#define NUM_OF_RUNS 5 #define NUM_OF_RUNS 5
static int static int
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment