Commit efd85cf8 authored by Joe Perches's avatar Joe Perches Committed by Darren Hart

thinkpad_acpi: Remove side effects from vdbg_printk -> no_printk macro

vdbg_printk when not using CONFIG_THINKPAD_ACPI_DEBUG uses
no_printk which produces no logging output but always
evaluates arguments.

Change the macro to surround the no_printk call with
	do { if (0) no_printk(...); } while (0)
to avoid the unnecessary argument evaluations.

$ size drivers/platform/x86/thinkpad_acpi.o*
   text	   data	    bss	    dec	    hex	filename
  60918	   6184	    824	  67926	  10956	drivers/platform/x86/thinkpad_acpi.o.new
  60927	   6184	    824	  67935	  1095f	drivers/platform/x86/thinkpad_acpi.o.old
Signed-off-by: default avatarJoe Perches <joe@perches.com>
Acked-by: default avatarHenrique de Moraes Holschuh <hmh@hmh.eng.br>
Signed-off-by: default avatarDarren Hart <dvhart@linux.intel.com>
parent 2508a45a
...@@ -402,7 +402,7 @@ static const char *str_supported(int is_supported); ...@@ -402,7 +402,7 @@ static const char *str_supported(int is_supported);
#else #else
static inline const char *str_supported(int is_supported) { return ""; } static inline const char *str_supported(int is_supported) { return ""; }
#define vdbg_printk(a_dbg_level, format, arg...) \ #define vdbg_printk(a_dbg_level, format, arg...) \
no_printk(format, ##arg) do { if (0) no_printk(format, ##arg); } while (0)
#endif #endif
static void tpacpi_log_usertask(const char * const what) static void tpacpi_log_usertask(const char * const what)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment