Commit f02f07a4 authored by Eric Dumazet's avatar Eric Dumazet Committed by Luis Henriques

net: graceful exit from netif_alloc_netdev_queues()

commit d339727c upstream.

User space can crash kernel with

ip link add ifb10 numtxqueues 100000 type ifb

We must replace a BUG_ON() by proper test and return -EINVAL for
crazy values.

Fixes: 60877a32 ("net: allow large number of tx queues")
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent e64a0c1a
...@@ -6049,7 +6049,8 @@ static int netif_alloc_netdev_queues(struct net_device *dev) ...@@ -6049,7 +6049,8 @@ static int netif_alloc_netdev_queues(struct net_device *dev)
struct netdev_queue *tx; struct netdev_queue *tx;
size_t sz = count * sizeof(*tx); size_t sz = count * sizeof(*tx);
BUG_ON(count < 1 || count > 0xffff); if (count < 1 || count > 0xffff)
return -EINVAL;
tx = kzalloc(sz, GFP_KERNEL | __GFP_NOWARN | __GFP_REPEAT); tx = kzalloc(sz, GFP_KERNEL | __GFP_NOWARN | __GFP_REPEAT);
if (!tx) { if (!tx) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment