Commit f0c5b35c authored by roel kluin's avatar roel kluin Committed by David S. Miller

eexpress: Read buffer overflow

start_code is 69 words, but the code always writes a multiple of 16 words,
so the last 11 words written are outside the array.
Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a3e8ee68
...@@ -1474,13 +1474,13 @@ static void eexp_hw_init586(struct net_device *dev) ...@@ -1474,13 +1474,13 @@ static void eexp_hw_init586(struct net_device *dev)
outw(0x0000, ioaddr + 0x800c); outw(0x0000, ioaddr + 0x800c);
outw(0x0000, ioaddr + 0x800e); outw(0x0000, ioaddr + 0x800e);
for (i = 0; i < (sizeof(start_code)); i+=32) { for (i = 0; i < ARRAY_SIZE(start_code) * 2; i+=32) {
int j; int j;
outw(i, ioaddr + SM_PTR); outw(i, ioaddr + SM_PTR);
for (j = 0; j < 16; j+=2) for (j = 0; j < 16 && (i+j)/2 < ARRAY_SIZE(start_code); j+=2)
outw(start_code[(i+j)/2], outw(start_code[(i+j)/2],
ioaddr+0x4000+j); ioaddr+0x4000+j);
for (j = 0; j < 16; j+=2) for (j = 0; j < 16 && (i+j+16)/2 < ARRAY_SIZE(start_code); j+=2)
outw(start_code[(i+j+16)/2], outw(start_code[(i+j+16)/2],
ioaddr+0x8000+j); ioaddr+0x8000+j);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment