Commit f19f916d authored by Wei Yongjun's avatar Wei Yongjun Committed by David S. Miller

net: stmmac: fix return value check in socfpga_dwmac_parse_data()

In case of error, the function devm_ioremap_resource() returns
ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().
Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3ce62a84
...@@ -120,9 +120,9 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac *dwmac, struct device * ...@@ -120,9 +120,9 @@ static int socfpga_dwmac_parse_data(struct socfpga_dwmac *dwmac, struct device *
} }
dwmac->splitter_base = devm_ioremap_resource(dev, &res_splitter); dwmac->splitter_base = devm_ioremap_resource(dev, &res_splitter);
if (!dwmac->splitter_base) { if (IS_ERR(dwmac->splitter_base)) {
dev_info(dev, "Failed to mapping emac splitter\n"); dev_info(dev, "Failed to mapping emac splitter\n");
return -EINVAL; return PTR_ERR(dwmac->splitter_base);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment