Commit f2620e7f authored by Julia Lawall's avatar Julia Lawall Committed by Guenter Roeck

hwmon: (f71882fg) use permission-specific DEVICE_ATTR variants

Use DEVICE_ATTR_RO for read-only attributes. This simplifies the source
code, improves readbility, and reduces the chance of inconsistencies.

The conversion was done automatically using coccinelle. It was validated
by compiling both the old and the new source code and comparing its text,
data, and bss size.
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
[groeck: Updated description]
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 345d52fa
...@@ -390,7 +390,7 @@ static ssize_t show_pwm_auto_point_temp(struct device *dev, ...@@ -390,7 +390,7 @@ static ssize_t show_pwm_auto_point_temp(struct device *dev,
static ssize_t store_pwm_auto_point_temp(struct device *dev, static ssize_t store_pwm_auto_point_temp(struct device *dev,
struct device_attribute *devattr, const char *buf, size_t count); struct device_attribute *devattr, const char *buf, size_t count);
/* Sysfs misc */ /* Sysfs misc */
static ssize_t show_name(struct device *dev, struct device_attribute *devattr, static ssize_t name_show(struct device *dev, struct device_attribute *devattr,
char *buf); char *buf);
static int f71882fg_probe(struct platform_device *pdev); static int f71882fg_probe(struct platform_device *pdev);
...@@ -404,7 +404,7 @@ static struct platform_driver f71882fg_driver = { ...@@ -404,7 +404,7 @@ static struct platform_driver f71882fg_driver = {
.remove = f71882fg_remove, .remove = f71882fg_remove,
}; };
static DEVICE_ATTR(name, S_IRUGO, show_name, NULL); static DEVICE_ATTR_RO(name);
/* /*
* Temp attr for the f71858fg, the f71858fg is special as it has its * Temp attr for the f71858fg, the f71858fg is special as it has its
...@@ -2212,7 +2212,7 @@ static ssize_t store_pwm_auto_point_temp(struct device *dev, ...@@ -2212,7 +2212,7 @@ static ssize_t store_pwm_auto_point_temp(struct device *dev,
return count; return count;
} }
static ssize_t show_name(struct device *dev, struct device_attribute *devattr, static ssize_t name_show(struct device *dev, struct device_attribute *devattr,
char *buf) char *buf)
{ {
struct f71882fg_data *data = dev_get_drvdata(dev); struct f71882fg_data *data = dev_get_drvdata(dev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment