Commit f28ba80c authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

misc: mic: double free on ioctl error path

commit 816c9311 upstream.

This function only has one caller.  Freeing "vdev" here leads to a use
after free bug.  There are several other error paths in this function
but this is the only one which frees "vdev".  It looks like the kfree()
can be safely removed.

Fixes: 61e9c905 ("misc: mic: Enable VOP host side functionality")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 02d009e8
...@@ -292,7 +292,6 @@ static int vop_virtio_add_device(struct vop_vdev *vdev, ...@@ -292,7 +292,6 @@ static int vop_virtio_add_device(struct vop_vdev *vdev,
if (ret) { if (ret) {
dev_err(vop_dev(vdev), "%s %d err %d\n", dev_err(vop_dev(vdev), "%s %d err %d\n",
__func__, __LINE__, ret); __func__, __LINE__, ret);
kfree(vdev);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment