Commit f354169e authored by Anand Moon's avatar Anand Moon Committed by Guenter Roeck

hwmon: (pwm-fan) Update the duty cycle inorder to control the pwm-fan

pwm_config() must be called with a duty cycle of 0 prior to calling
pwm_disable() to ensure that the pwm signal is set to low.
Reported-by: default avatarMarkus Reichl <m.reichl@fivetechno.de>
Tested-by: default avatarMarkus Reichl <m.reichl@fivetechno.de>
Reviewed-by: default avatarLukasz Majewski <l.majewski@samsung.com>
Reviewed-by: default avatarSjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: default avatarAnand Moon <linux.amoon@gmail.com>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent f83a9cb6
...@@ -47,23 +47,20 @@ static int __set_pwm(struct pwm_fan_ctx *ctx, unsigned long pwm) ...@@ -47,23 +47,20 @@ static int __set_pwm(struct pwm_fan_ctx *ctx, unsigned long pwm)
if (ctx->pwm_value == pwm) if (ctx->pwm_value == pwm)
goto exit_set_pwm_err; goto exit_set_pwm_err;
if (pwm == 0) {
pwm_disable(ctx->pwm);
goto exit_set_pwm;
}
duty = DIV_ROUND_UP(pwm * (ctx->pwm->period - 1), MAX_PWM); duty = DIV_ROUND_UP(pwm * (ctx->pwm->period - 1), MAX_PWM);
ret = pwm_config(ctx->pwm, duty, ctx->pwm->period); ret = pwm_config(ctx->pwm, duty, ctx->pwm->period);
if (ret) if (ret)
goto exit_set_pwm_err; goto exit_set_pwm_err;
if (pwm == 0)
pwm_disable(ctx->pwm);
if (ctx->pwm_value == 0) { if (ctx->pwm_value == 0) {
ret = pwm_enable(ctx->pwm); ret = pwm_enable(ctx->pwm);
if (ret) if (ret)
goto exit_set_pwm_err; goto exit_set_pwm_err;
} }
exit_set_pwm:
ctx->pwm_value = pwm; ctx->pwm_value = pwm;
exit_set_pwm_err: exit_set_pwm_err:
mutex_unlock(&ctx->lock); mutex_unlock(&ctx->lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment