Commit f354c845 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman

USB: usbatm.c: move assignment out of if () block

We should not be doing assignments within an if () block
so fix up the code to not do this.

change was created using Coccinelle.

CC: Duncan Sands <duncan.sands@free.fr>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: default avatarFelipe Balbi <balbi@ti.com>
parent 3383ee4c
...@@ -382,7 +382,8 @@ static void usbatm_extract_one_cell(struct usbatm_data *instance, unsigned char ...@@ -382,7 +382,8 @@ static void usbatm_extract_one_cell(struct usbatm_data *instance, unsigned char
"%s: got packet (length: %u, pdu_length: %u, vcc: 0x%p)", "%s: got packet (length: %u, pdu_length: %u, vcc: 0x%p)",
__func__, length, pdu_length, vcc); __func__, length, pdu_length, vcc);
if (!(skb = dev_alloc_skb(length))) { skb = dev_alloc_skb(length);
if (!skb) {
if (printk_ratelimit()) if (printk_ratelimit())
atm_err(instance, "%s: no memory for skb (length: %u)!\n", atm_err(instance, "%s: no memory for skb (length: %u)!\n",
__func__, length); __func__, length);
...@@ -816,7 +817,8 @@ static int usbatm_atm_open(struct atm_vcc *vcc) ...@@ -816,7 +817,8 @@ static int usbatm_atm_open(struct atm_vcc *vcc)
goto fail; goto fail;
} }
if (!(new = kzalloc(sizeof(struct usbatm_vcc_data), GFP_KERNEL))) { new = kzalloc(sizeof(struct usbatm_vcc_data), GFP_KERNEL);
if (!new) {
atm_err(instance, "%s: no memory for vcc_data!\n", __func__); atm_err(instance, "%s: no memory for vcc_data!\n", __func__);
ret = -ENOMEM; ret = -ENOMEM;
goto fail; goto fail;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment