Commit f40fe91c authored by Dan Rosenberg's avatar Dan Rosenberg Committed by Greg Kroah-Hartman

ARM: 6891/1: prevent heap corruption in OABI semtimedop

commit 0f22072a upstream.

When CONFIG_OABI_COMPAT is set, the wrapper for semtimedop does not
bound the nsops argument.  A sufficiently large value will cause an
integer overflow in allocation size, followed by copying too much data
into the allocated buffer.  Fix this by restricting nsops to SEMOPM.
Untested.
Signed-off-by: default avatarDan Rosenberg <drosenberg@vsecurity.com>
Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 1edf9b93
...@@ -311,7 +311,7 @@ asmlinkage long sys_oabi_semtimedop(int semid, ...@@ -311,7 +311,7 @@ asmlinkage long sys_oabi_semtimedop(int semid,
long err; long err;
int i; int i;
if (nsops < 1) if (nsops < 1 || nsops > SEMOPM)
return -EINVAL; return -EINVAL;
sops = kmalloc(sizeof(*sops) * nsops, GFP_KERNEL); sops = kmalloc(sizeof(*sops) * nsops, GFP_KERNEL);
if (!sops) if (!sops)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment