Commit f62438ac authored by Paul Walmsley's avatar Paul Walmsley Committed by Takashi Iwai

ALSA: at73c213: clk_round_rate() can return a zero upon error

Treat both negative and zero return values from clk_round_rate()
as errors.  This is needed since subsequent patches will convert
clk_round_rate()'s return value to be an unsigned type, rather
than a signed type, since some clock sources can generate rates higher
than (2^31)-1 Hz.

Eventually, when calling clk_round_rate(), only a return value of
zero will be considered a error.  All other values will be
considered valid rates.  The comparison against values less than
0 is kept to preserve the correct behavior in the meantime.
Signed-off-by: default avatarPaul Walmsley <pwalmsley@nvidia.com>
Acked-by: default avatarHans-Christian Egtvedt <egtvedt@samfundet.no>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent ed326363
...@@ -174,7 +174,7 @@ static int snd_at73c213_set_bitrate(struct snd_at73c213 *chip) ...@@ -174,7 +174,7 @@ static int snd_at73c213_set_bitrate(struct snd_at73c213 *chip)
dac_rate_new = 8 * (ssc_rate / ssc_div); dac_rate_new = 8 * (ssc_rate / ssc_div);
status = clk_round_rate(chip->board->dac_clk, dac_rate_new); status = clk_round_rate(chip->board->dac_clk, dac_rate_new);
if (status < 0) if (status <= 0)
return status; return status;
/* Ignore difference smaller than 256 Hz. */ /* Ignore difference smaller than 256 Hz. */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment