Commit f625e0fd authored by Guenter Roeck's avatar Guenter Roeck

hwmon: (tmp421) Convert to use devm_ functions

Convert to use devm_ functions to reduce code size and simplify the code.
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Acked-by: default avatarJean Delvare <khali@linux-fr.org>
parent 0df9fc7b
...@@ -267,7 +267,8 @@ static int tmp421_probe(struct i2c_client *client, ...@@ -267,7 +267,8 @@ static int tmp421_probe(struct i2c_client *client,
struct tmp421_data *data; struct tmp421_data *data;
int err; int err;
data = kzalloc(sizeof(struct tmp421_data), GFP_KERNEL); data = devm_kzalloc(&client->dev, sizeof(struct tmp421_data),
GFP_KERNEL);
if (!data) if (!data)
return -ENOMEM; return -ENOMEM;
...@@ -277,11 +278,11 @@ static int tmp421_probe(struct i2c_client *client, ...@@ -277,11 +278,11 @@ static int tmp421_probe(struct i2c_client *client,
err = tmp421_init_client(client); err = tmp421_init_client(client);
if (err) if (err)
goto exit_free; return err;
err = sysfs_create_group(&client->dev.kobj, &tmp421_group); err = sysfs_create_group(&client->dev.kobj, &tmp421_group);
if (err) if (err)
goto exit_free; return err;
data->hwmon_dev = hwmon_device_register(&client->dev); data->hwmon_dev = hwmon_device_register(&client->dev);
if (IS_ERR(data->hwmon_dev)) { if (IS_ERR(data->hwmon_dev)) {
...@@ -293,10 +294,6 @@ static int tmp421_probe(struct i2c_client *client, ...@@ -293,10 +294,6 @@ static int tmp421_probe(struct i2c_client *client,
exit_remove: exit_remove:
sysfs_remove_group(&client->dev.kobj, &tmp421_group); sysfs_remove_group(&client->dev.kobj, &tmp421_group);
exit_free:
kfree(data);
return err; return err;
} }
...@@ -307,8 +304,6 @@ static int tmp421_remove(struct i2c_client *client) ...@@ -307,8 +304,6 @@ static int tmp421_remove(struct i2c_client *client)
hwmon_device_unregister(data->hwmon_dev); hwmon_device_unregister(data->hwmon_dev);
sysfs_remove_group(&client->dev.kobj, &tmp421_group); sysfs_remove_group(&client->dev.kobj, &tmp421_group);
kfree(data);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment