Commit f6bca4d9 authored by Timo Sigurdsson's avatar Timo Sigurdsson Committed by Jens Axboe

ata: ahci_sunxi: Disable DIPM

DIPM is unsupported or broken on sunxi. Trying to enable the power
management policy med_power_with_dipm on an Allwinner A20 SoC based board
leads to immediate I/O errors and the attached SATA disk disappears from
the /dev filesystem. A reset (power cycle) is required to make the SATA
controller or disk work again. The A10 and A20 SoC data sheets and manuals
don't mention DIPM at all [1], so it's fair to assume that it's simply not
supported. But even if it was, it should be considered broken and best be
disabled in the ahci_sunxi driver.

[1] https://github.com/allwinner-zh/documents/tree/master/

Fixes: c5754b52 ("ARM: sunxi: Add support for Allwinner SUNXi SoCs sata to ahci_platform")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarTimo Sigurdsson <public_timo.s@silentcreek.de>
Tested-by: default avatarTimo Sigurdsson <public_timo.s@silentcreek.de>
Link: https://lore.kernel.org/r/20210614072539.3307-1-public_timo.s@silentcreek.deSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 44b1fbc0
...@@ -200,7 +200,7 @@ static void ahci_sunxi_start_engine(struct ata_port *ap) ...@@ -200,7 +200,7 @@ static void ahci_sunxi_start_engine(struct ata_port *ap)
} }
static const struct ata_port_info ahci_sunxi_port_info = { static const struct ata_port_info ahci_sunxi_port_info = {
.flags = AHCI_FLAG_COMMON | ATA_FLAG_NCQ, .flags = AHCI_FLAG_COMMON | ATA_FLAG_NCQ | ATA_FLAG_NO_DIPM,
.pio_mask = ATA_PIO4, .pio_mask = ATA_PIO4,
.udma_mask = ATA_UDMA6, .udma_mask = ATA_UDMA6,
.port_ops = &ahci_platform_ops, .port_ops = &ahci_platform_ops,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment