Commit f77597b2 authored by Herbert Xu's avatar Herbert Xu Committed by Greg Kroah-Hartman

crypto: af_alg - Fix socket double-free when accept fails

commit a383292c upstream.

When we fail an accept(2) call we will end up freeing the socket
twice, once due to the direct sk_free call and once again through
newsock.

This patch fixes this by removing the sk_free call.
Reported-by: default avatarDmitry Vyukov <dvyukov@google.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5a707f09
...@@ -275,10 +275,8 @@ int af_alg_accept(struct sock *sk, struct socket *newsock) ...@@ -275,10 +275,8 @@ int af_alg_accept(struct sock *sk, struct socket *newsock)
security_sk_clone(sk, sk2); security_sk_clone(sk, sk2);
err = type->accept(ask->private, sk2); err = type->accept(ask->private, sk2);
if (err) { if (err)
sk_free(sk2);
goto unlock; goto unlock;
}
sk2->sk_family = PF_ALG; sk2->sk_family = PF_ALG;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment