Commit f80f868e authored by Mike Christie's avatar Mike Christie Committed by James Bottomley

[SCSI] iscsi class: fix endpoint leak

class_find_device gets a ref to the device so we must release it.
The class will serialize access to the ep so we do not have to worry
about a remove racing with the callers access, so we can simplify the
use and drop the ref right away.
Signed-off-by: default avatarMike Christie <michaelc@cs.wisc.edu>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
parent 4c2133c8
...@@ -219,6 +219,7 @@ EXPORT_SYMBOL_GPL(iscsi_destroy_endpoint); ...@@ -219,6 +219,7 @@ EXPORT_SYMBOL_GPL(iscsi_destroy_endpoint);
struct iscsi_endpoint *iscsi_lookup_endpoint(u64 handle) struct iscsi_endpoint *iscsi_lookup_endpoint(u64 handle)
{ {
struct iscsi_endpoint *ep;
struct device *dev; struct device *dev;
dev = class_find_device(&iscsi_endpoint_class, &handle, dev = class_find_device(&iscsi_endpoint_class, &handle,
...@@ -226,7 +227,13 @@ struct iscsi_endpoint *iscsi_lookup_endpoint(u64 handle) ...@@ -226,7 +227,13 @@ struct iscsi_endpoint *iscsi_lookup_endpoint(u64 handle)
if (!dev) if (!dev)
return NULL; return NULL;
return iscsi_dev_to_endpoint(dev); ep = iscsi_dev_to_endpoint(dev);
/*
* we can drop this now because the interface will prevent
* removals and lookups from racing.
*/
put_device(dev);
return ep;
} }
EXPORT_SYMBOL_GPL(iscsi_lookup_endpoint); EXPORT_SYMBOL_GPL(iscsi_lookup_endpoint);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment