Commit f83c29f4 authored by Uwe Kleine-König's avatar Uwe Kleine-König

pwm: samsung: Simplify using dev_err_probe()

dev_err_probe() simplifies and improves the idiom "emit error message +
return error code". Apply it accordingly.

Link: https://lore.kernel.org/r/27a55fc05eb13802c9eddc600d0460e279388999.1707900770.git.u.kleine-koenig@pengutronix.deSigned-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
parent ef2092b5
...@@ -564,10 +564,9 @@ static int pwm_samsung_probe(struct platform_device *pdev) ...@@ -564,10 +564,9 @@ static int pwm_samsung_probe(struct platform_device *pdev)
if (ret) if (ret)
return ret; return ret;
} else { } else {
if (!pdev->dev.platform_data) { if (!pdev->dev.platform_data)
dev_err(&pdev->dev, "no platform data specified\n"); return dev_err_probe(&pdev->dev, -EINVAL,
return -EINVAL; "no platform data specified\n");
}
memcpy(&our_chip->variant, pdev->dev.platform_data, memcpy(&our_chip->variant, pdev->dev.platform_data,
sizeof(our_chip->variant)); sizeof(our_chip->variant));
...@@ -578,10 +577,9 @@ static int pwm_samsung_probe(struct platform_device *pdev) ...@@ -578,10 +577,9 @@ static int pwm_samsung_probe(struct platform_device *pdev)
return PTR_ERR(our_chip->base); return PTR_ERR(our_chip->base);
our_chip->base_clk = devm_clk_get_enabled(&pdev->dev, "timers"); our_chip->base_clk = devm_clk_get_enabled(&pdev->dev, "timers");
if (IS_ERR(our_chip->base_clk)) { if (IS_ERR(our_chip->base_clk))
dev_err(dev, "failed to get timer base clk\n"); return dev_err_probe(dev, PTR_ERR(our_chip->base_clk),
return PTR_ERR(our_chip->base_clk); "failed to get timer base clk\n");
}
for (chan = 0; chan < SAMSUNG_PWM_NUM; ++chan) for (chan = 0; chan < SAMSUNG_PWM_NUM; ++chan)
if (our_chip->variant.output_mask & BIT(chan)) if (our_chip->variant.output_mask & BIT(chan))
...@@ -594,10 +592,8 @@ static int pwm_samsung_probe(struct platform_device *pdev) ...@@ -594,10 +592,8 @@ static int pwm_samsung_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, chip); platform_set_drvdata(pdev, chip);
ret = devm_pwmchip_add(&pdev->dev, chip); ret = devm_pwmchip_add(&pdev->dev, chip);
if (ret < 0) { if (ret < 0)
dev_err(dev, "failed to register PWM chip\n"); return dev_err_probe(dev, ret, "failed to register PWM chip\n");
return ret;
}
dev_dbg(dev, "base_clk at %lu, tclk0 at %lu, tclk1 at %lu\n", dev_dbg(dev, "base_clk at %lu, tclk0 at %lu, tclk1 at %lu\n",
clk_get_rate(our_chip->base_clk), clk_get_rate(our_chip->base_clk),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment