Commit f910b6cb authored by Markus Elfring's avatar Markus Elfring Committed by Greg Kroah-Hartman

USB: PCI-quirks: Deletion of unnecessary checks before the function call "pci_dev_put"

The pci_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.
Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bb2d43e0
...@@ -233,10 +233,8 @@ int usb_amd_find_chipset_info(void) ...@@ -233,10 +233,8 @@ int usb_amd_find_chipset_info(void)
spin_unlock_irqrestore(&amd_lock, flags); spin_unlock_irqrestore(&amd_lock, flags);
if (info.nb_dev) pci_dev_put(info.nb_dev);
pci_dev_put(info.nb_dev); pci_dev_put(info.smbus_dev);
if (info.smbus_dev)
pci_dev_put(info.smbus_dev);
} else { } else {
/* no race - commit the result */ /* no race - commit the result */
...@@ -447,10 +445,8 @@ void usb_amd_dev_put(void) ...@@ -447,10 +445,8 @@ void usb_amd_dev_put(void)
spin_unlock_irqrestore(&amd_lock, flags); spin_unlock_irqrestore(&amd_lock, flags);
if (nb) pci_dev_put(nb);
pci_dev_put(nb); pci_dev_put(smbus);
if (smbus)
pci_dev_put(smbus);
} }
EXPORT_SYMBOL_GPL(usb_amd_dev_put); EXPORT_SYMBOL_GPL(usb_amd_dev_put);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment