Commit f9723837 authored by Eric Biggers's avatar Eric Biggers Committed by Rafael J. Wysocki

PM / sleep: declare __tracedata symbols as char[] rather than char

Accessing more than one byte from a symbol declared simply 'char' is undefined
behavior, as reported by UBSAN:

	UBSAN: Undefined behaviour in drivers/base/power/trace.c:178:18
	load of address ffffffff8203fc78 with insufficient space
	for an object of type 'char'

Avoid this by declaring the symbols as arrays.
Signed-off-by: default avatarEric Biggers <ebiggers3@gmail.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 388f7b1d
...@@ -166,14 +166,14 @@ void generate_pm_trace(const void *tracedata, unsigned int user) ...@@ -166,14 +166,14 @@ void generate_pm_trace(const void *tracedata, unsigned int user)
} }
EXPORT_SYMBOL(generate_pm_trace); EXPORT_SYMBOL(generate_pm_trace);
extern char __tracedata_start, __tracedata_end; extern char __tracedata_start[], __tracedata_end[];
static int show_file_hash(unsigned int value) static int show_file_hash(unsigned int value)
{ {
int match; int match;
char *tracedata; char *tracedata;
match = 0; match = 0;
for (tracedata = &__tracedata_start ; tracedata < &__tracedata_end ; for (tracedata = __tracedata_start ; tracedata < __tracedata_end ;
tracedata += 2 + sizeof(unsigned long)) { tracedata += 2 + sizeof(unsigned long)) {
unsigned short lineno = *(unsigned short *)tracedata; unsigned short lineno = *(unsigned short *)tracedata;
const char *file = *(const char **)(tracedata + 2); const char *file = *(const char **)(tracedata + 2);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment