Commit fa1321b1 authored by Jakob Koschel's avatar Jakob Koschel Committed by Michael Ellerman

powerpc/sysdev: fix incorrect use to determine if list is empty

'gtm' will *always* be set by list_for_each_entry().
It is incorrect to assume that the iterator value will be NULL if the
list is empty.

Instead of checking the pointer it should be checked if
the list is empty.

Fixes: 83ff9dcf ("powerpc/sysdev: implement FSL GTM support")
Signed-off-by: default avatarJakob Koschel <jakobkoschel@gmail.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220228142434.576226-1-jakobkoschel@gmail.com
parent 37e67648
...@@ -86,7 +86,7 @@ static LIST_HEAD(gtms); ...@@ -86,7 +86,7 @@ static LIST_HEAD(gtms);
*/ */
struct gtm_timer *gtm_get_timer16(void) struct gtm_timer *gtm_get_timer16(void)
{ {
struct gtm *gtm = NULL; struct gtm *gtm;
int i; int i;
list_for_each_entry(gtm, &gtms, list_node) { list_for_each_entry(gtm, &gtms, list_node) {
...@@ -103,7 +103,7 @@ struct gtm_timer *gtm_get_timer16(void) ...@@ -103,7 +103,7 @@ struct gtm_timer *gtm_get_timer16(void)
spin_unlock_irq(&gtm->lock); spin_unlock_irq(&gtm->lock);
} }
if (gtm) if (!list_empty(&gtms))
return ERR_PTR(-EBUSY); return ERR_PTR(-EBUSY);
return ERR_PTR(-ENODEV); return ERR_PTR(-ENODEV);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment