Commit fa255f51 authored by Heiko Carstens's avatar Heiko Carstens Committed by Martin Schwidefsky

s390/uaccess: fix possible register corruption in strnlen_user_srst()

The whole point of the out-of-line strnlen_user_srst() function was to
avoid corruption of register 0 due to register asm assignment.
However 'somebody' :) forgot to remove the update_primary_asce() function
call, which may clobber register 0 contents.
So let's remove that call and also move the size check to the calling
function.
Signed-off-by: default avatarHeiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
parent a960062e
...@@ -338,9 +338,6 @@ static inline unsigned long strnlen_user_srst(const char __user *src, ...@@ -338,9 +338,6 @@ static inline unsigned long strnlen_user_srst(const char __user *src,
register unsigned long reg0 asm("0") = 0; register unsigned long reg0 asm("0") = 0;
unsigned long tmp1, tmp2; unsigned long tmp1, tmp2;
if (unlikely(!size))
return 0;
update_primary_asce(current);
asm volatile( asm volatile(
" la %2,0(%1)\n" " la %2,0(%1)\n"
" la %3,0(%0,%1)\n" " la %3,0(%0,%1)\n"
...@@ -359,6 +356,8 @@ static inline unsigned long strnlen_user_srst(const char __user *src, ...@@ -359,6 +356,8 @@ static inline unsigned long strnlen_user_srst(const char __user *src,
unsigned long __strnlen_user(const char __user *src, unsigned long size) unsigned long __strnlen_user(const char __user *src, unsigned long size)
{ {
if (unlikely(!size))
return 0;
update_primary_asce(current); update_primary_asce(current);
return strnlen_user_srst(src, size); return strnlen_user_srst(src, size);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment