Commit fab413a3 authored by Cedric Le Goater's avatar Cedric Le Goater Committed by Linus Torvalds

[PATCH] namespaces: exit_task_namespaces() invalidates nsproxy

exit_task_namespaces() has replaced the former exit_namespace().  It
invalidates task->nsproxy and associated namespaces.  This is an issue for
the (futur) pid namespace which is required to be valid in exit_notify().

This patch moves exit_task_namespaces() after exit_notify() to keep nsproxy
valid.
Signed-off-by: default avatarCedric Le Goater <clg@fr.ibm.com>
Cc: Serge E. Hallyn <serue@us.ibm.com>
Cc: Kirill Korotaev <dev@openvz.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Herbert Poetzl <herbert@13thfloor.at>
Cc: Andrey Savochkin <saw@sw.ru>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 1651e14e
...@@ -920,7 +920,6 @@ fastcall NORET_TYPE void do_exit(long code) ...@@ -920,7 +920,6 @@ fastcall NORET_TYPE void do_exit(long code)
exit_sem(tsk); exit_sem(tsk);
__exit_files(tsk); __exit_files(tsk);
__exit_fs(tsk); __exit_fs(tsk);
exit_task_namespaces(tsk);
exit_thread(); exit_thread();
cpuset_exit(tsk); cpuset_exit(tsk);
exit_keys(tsk); exit_keys(tsk);
...@@ -935,6 +934,7 @@ fastcall NORET_TYPE void do_exit(long code) ...@@ -935,6 +934,7 @@ fastcall NORET_TYPE void do_exit(long code)
tsk->exit_code = code; tsk->exit_code = code;
proc_exit_connector(tsk); proc_exit_connector(tsk);
exit_notify(tsk); exit_notify(tsk);
exit_task_namespaces(tsk);
#ifdef CONFIG_NUMA #ifdef CONFIG_NUMA
mpol_free(tsk->mempolicy); mpol_free(tsk->mempolicy);
tsk->mempolicy = NULL; tsk->mempolicy = NULL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment