Commit fac90e80 authored by David Woodhouse's avatar David Woodhouse Committed by Ben Hutchings

iommu/vt-d: Fix missing IOTLB flush in intel_iommu_unmap()

Part of commit ea8ea460 upstream.

This missing IOTLB flush was added as a minor, inconsequential bug-fix
in commit ea8ea460 ("iommu/vt-d: Clean up and fix page table clear/free
behaviour") in 3.15. It wasn't originally intended for -stable but a
couple of users have reported issues which turn out to be fixed by
adding the missing flush.
Signed-off-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
[bwh: Backported to 3.2:
 - Adjust context
 - Use &dmar_domain->iommu_bmp, as it is a single word not an array]
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
parent 30c7c6df
...@@ -4070,7 +4070,7 @@ static int intel_iommu_unmap(struct iommu_domain *domain, ...@@ -4070,7 +4070,7 @@ static int intel_iommu_unmap(struct iommu_domain *domain,
{ {
struct dmar_domain *dmar_domain = domain->priv; struct dmar_domain *dmar_domain = domain->priv;
size_t size = PAGE_SIZE << gfp_order; size_t size = PAGE_SIZE << gfp_order;
int order; int order, iommu_id;
order = dma_pte_clear_range(dmar_domain, iova >> VTD_PAGE_SHIFT, order = dma_pte_clear_range(dmar_domain, iova >> VTD_PAGE_SHIFT,
(iova + size - 1) >> VTD_PAGE_SHIFT); (iova + size - 1) >> VTD_PAGE_SHIFT);
...@@ -4078,6 +4078,22 @@ static int intel_iommu_unmap(struct iommu_domain *domain, ...@@ -4078,6 +4078,22 @@ static int intel_iommu_unmap(struct iommu_domain *domain,
if (dmar_domain->max_addr == iova + size) if (dmar_domain->max_addr == iova + size)
dmar_domain->max_addr = iova; dmar_domain->max_addr = iova;
for_each_set_bit(iommu_id, &dmar_domain->iommu_bmp, g_num_of_iommus) {
struct intel_iommu *iommu = g_iommus[iommu_id];
int num, ndomains;
/*
* find bit position of dmar_domain
*/
ndomains = cap_ndoms(iommu->cap);
for_each_set_bit(num, iommu->domain_ids, ndomains) {
if (iommu->domains[num] == dmar_domain)
iommu_flush_iotlb_psi(iommu, num,
iova >> VTD_PAGE_SHIFT,
1 << order, 0);
}
}
return order; return order;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment