Commit fb3ec7ba authored by Sudip Mukherjee's avatar Sudip Mukherjee Committed by Marc Kleine-Budde

can: xilinx_can: fix comparison of unsigned variable

The variable err was of the type u32. It was being compared with < 0, and being
an unsigned variable the comparison would have been always false.

Moreover, err was getting the return value from set_reset_mode() and
xcan_set_bittiming(), and both are returning int.
Signed-off-by: default avatarSudip Mukherjee <sudip@vectorindia.org>
Reviewed-by: default avatarMichal Simek <michal.simek@xilinx.com>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 4e2061b1
...@@ -300,7 +300,8 @@ static int xcan_set_bittiming(struct net_device *ndev) ...@@ -300,7 +300,8 @@ static int xcan_set_bittiming(struct net_device *ndev)
static int xcan_chip_start(struct net_device *ndev) static int xcan_chip_start(struct net_device *ndev)
{ {
struct xcan_priv *priv = netdev_priv(ndev); struct xcan_priv *priv = netdev_priv(ndev);
u32 err, reg_msr, reg_sr_mask; u32 reg_msr, reg_sr_mask;
int err;
unsigned long timeout; unsigned long timeout;
/* Check if it is in reset mode */ /* Check if it is in reset mode */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment