Commit fbc2bd7e authored by Filipe Manana's avatar Filipe Manana Committed by David Sterba

btrfs: release old extent maps during page release

When removing an extent map at try_release_extent_mapping(), called through
the page release callback (btrfs_releasepage()), we never release an extent
map that is in the list of modified extents. This is to prevent races with
a concurrent fsync using the fast path, which could lead to not logging an
extent created in the current transaction.

However we can safely remove an extent map created in a past transaction
that is still in the list of modified extents (because no one fsynced yet
the inode after that transaction got commited), because such extents are
skipped during an fsync as it is pointless to log them. This change does
that.
Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 3d6448e6
...@@ -4481,6 +4481,9 @@ int try_release_extent_mapping(struct page *page, gfp_t mask) ...@@ -4481,6 +4481,9 @@ int try_release_extent_mapping(struct page *page, gfp_t mask)
page->mapping->host->i_size > SZ_16M) { page->mapping->host->i_size > SZ_16M) {
u64 len; u64 len;
while (start <= end) { while (start <= end) {
struct btrfs_fs_info *fs_info;
u64 cur_gen;
len = end - start + 1; len = end - start + 1;
write_lock(&map->lock); write_lock(&map->lock);
em = lookup_extent_mapping(map, start, len); em = lookup_extent_mapping(map, start, len);
...@@ -4505,13 +4508,27 @@ int try_release_extent_mapping(struct page *page, gfp_t mask) ...@@ -4505,13 +4508,27 @@ int try_release_extent_mapping(struct page *page, gfp_t mask)
* extra reference on the em. * extra reference on the em.
*/ */
if (list_empty(&em->list) || if (list_empty(&em->list) ||
test_bit(EXTENT_FLAG_LOGGING, &em->flags)) { test_bit(EXTENT_FLAG_LOGGING, &em->flags))
set_bit(BTRFS_INODE_NEEDS_FULL_SYNC, goto remove_em;
&btrfs_inode->runtime_flags); /*
remove_extent_mapping(map, em); * If it's in the list of modified extents, remove it
/* once for the rb tree */ * only if its generation is older then the current one,
free_extent_map(em); * in which case we don't need it for a fast fsync.
} * Otherwise don't remove it, we could be racing with an
* ongoing fast fsync that could miss the new extent.
*/
fs_info = btrfs_inode->root->fs_info;
spin_lock(&fs_info->trans_lock);
cur_gen = fs_info->generation;
spin_unlock(&fs_info->trans_lock);
if (em->generation >= cur_gen)
goto next;
remove_em:
set_bit(BTRFS_INODE_NEEDS_FULL_SYNC,
&btrfs_inode->runtime_flags);
remove_extent_mapping(map, em);
/* once for the rb tree */
free_extent_map(em);
next: next:
start = extent_map_end(em); start = extent_map_end(em);
write_unlock(&map->lock); write_unlock(&map->lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment