Commit fc39fdca authored by Kristina Martšenko's avatar Kristina Martšenko Committed by Luis Henriques

iio: mxs-lradc: only update the buffer when its conversions have finished

commit 89bb35e2 upstream.

Using the touchscreen while running buffered capture results in the
buffer reporting lots of wrong values, often just zeros. This is because
we push readings to the buffer every time a touchscreen interrupt
arrives, including when the buffer's own conversions have not yet
finished. So let's only push to the buffer when its conversions are
ready.
Signed-off-by: default avatarKristina Martšenko <kristina.martsenko@gmail.com>
Reviewed-by: default avatarMarek Vasut <marex@denx.de>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
[ luis: backported to 3.16: adjusted context ]
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent 80f61dc5
...@@ -1157,10 +1157,12 @@ static irqreturn_t mxs_lradc_handle_irq(int irq, void *data) ...@@ -1157,10 +1157,12 @@ static irqreturn_t mxs_lradc_handle_irq(int irq, void *data)
LRADC_CTRL1_LRADC_IRQ(TOUCHSCREEN_VCHANNEL2)); LRADC_CTRL1_LRADC_IRQ(TOUCHSCREEN_VCHANNEL2));
} }
if (iio_buffer_enabled(iio)) if (iio_buffer_enabled(iio)) {
iio_trigger_poll(iio->trig, iio_get_time_ns()); if (reg & lradc->buffer_vchans)
else if (reg & LRADC_CTRL1_LRADC_IRQ(0)) iio_trigger_poll(iio->trig, iio_get_time_ns());
} else if (reg & LRADC_CTRL1_LRADC_IRQ(0)) {
complete(&lradc->completion); complete(&lradc->completion);
}
mxs_lradc_reg_clear(lradc, reg & clr_irq, LRADC_CTRL1); mxs_lradc_reg_clear(lradc, reg & clr_irq, LRADC_CTRL1);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment