Commit fc921566 authored by Eric Sandeen's avatar Eric Sandeen Committed by Dave Chinner

xfs: Ensure we have target_ip for RENAME_EXCHANGE

We shouldn't get here with RENAME_EXCHANGE set and no
target_ip, but let's be defensive, because xfs_cross_rename()
will dereference it.

Spotted by Coverity.
Signed-off-by: default avatarEric Sandeen <sandeen@redhat.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
parent 5885ebda
...@@ -2867,6 +2867,10 @@ xfs_rename( ...@@ -2867,6 +2867,10 @@ xfs_rename(
* Handle RENAME_EXCHANGE flags * Handle RENAME_EXCHANGE flags
*/ */
if (flags & RENAME_EXCHANGE) { if (flags & RENAME_EXCHANGE) {
if (target_ip == NULL) {
error = -EINVAL;
goto error_return;
}
error = xfs_cross_rename(tp, src_dp, src_name, src_ip, error = xfs_cross_rename(tp, src_dp, src_name, src_ip,
target_dp, target_name, target_ip, target_dp, target_name, target_ip,
&free_list, &first_block, spaceres); &free_list, &first_block, spaceres);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment