Commit fcb93ec3 authored by Dan Carpenter's avatar Dan Carpenter Committed by Robert Foss

drm/bridge: ti-sn65dsi86: fix a ternary type promotion bug

The ti_sn_aux_transfer() function returns ssize_t (signed long).  It's
supposed to return negative error codes or the number of bytes
transferred.  The "ret" variable is int and the "len" variable is
unsigned int.

The problem is that with a ternary like this, the negative int is first
type promoted to unsigned int to match "len" at this point it is a high
positive value.  Then when it is type promoted to ssize_t (s64) it
remains a high positive value instead of sign extending and becoming a
negative again.

Fix this by removing the ternary.

Fixes: b137406d ("drm/bridge: ti-sn65dsi86: If refclk, DP AUX can happen w/out pre-enable")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarRobert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/YKOGogHasIyvF8nj@mwanda
parent 409776fa
...@@ -1042,7 +1042,9 @@ static ssize_t ti_sn_aux_transfer(struct drm_dp_aux *aux, ...@@ -1042,7 +1042,9 @@ static ssize_t ti_sn_aux_transfer(struct drm_dp_aux *aux,
pm_runtime_mark_last_busy(pdata->dev); pm_runtime_mark_last_busy(pdata->dev);
pm_runtime_put_autosuspend(pdata->dev); pm_runtime_put_autosuspend(pdata->dev);
return ret ? ret : len; if (ret)
return ret;
return len;
} }
static int ti_sn_bridge_parse_dsi_host(struct ti_sn65dsi86 *pdata) static int ti_sn_bridge_parse_dsi_host(struct ti_sn65dsi86 *pdata)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment