Commit fd21b79e authored by Aditya Pakki's avatar Aditya Pakki Committed by Mika Westerberg

thunderbolt: Fix to check the return value of kmemdup

uuid in add_switch is allocted via kmemdup which can fail. The patch
logs the error and cleans up the allocated memory for switch.
Signed-off-by: default avatarAditya Pakki <pakki001@umn.edu>
Reviewed-by: default avatarMukesh Ojha <mojha@codeaurora.org>
Signed-off-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
parent 6183d5a5
...@@ -473,6 +473,11 @@ static void add_switch(struct tb_switch *parent_sw, u64 route, ...@@ -473,6 +473,11 @@ static void add_switch(struct tb_switch *parent_sw, u64 route,
goto out; goto out;
sw->uuid = kmemdup(uuid, sizeof(*uuid), GFP_KERNEL); sw->uuid = kmemdup(uuid, sizeof(*uuid), GFP_KERNEL);
if (!sw->uuid) {
tb_sw_warn(sw, "cannot allocate memory for switch\n");
tb_switch_put(sw);
goto out;
}
sw->connection_id = connection_id; sw->connection_id = connection_id;
sw->connection_key = connection_key; sw->connection_key = connection_key;
sw->link = link; sw->link = link;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment