Commit fd847b8e authored by José Roberto de Souza's avatar José Roberto de Souza Committed by Rodrigo Vivi

drm/i915: Do not modifiy reserved bit in gens that do not have IPC

IPC was only added in SKL+(actually we don't even enable for SKL due
WA) so without this change, driver was writing to a reserved bit.

Also removing the uncessary dev_priv->ipc_enabled = false; as now
gens without IPC will not have IPC enabled.

v2(Rodrigo):
- moved the new handling of WA #0477 to the next patch
Reviewed-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: default avatarJosé Roberto de Souza <jose.souza@intel.com>
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180918204714.27306-3-jose.souza@intel.com
parent 6edafc4e
...@@ -6117,6 +6117,9 @@ void intel_enable_ipc(struct drm_i915_private *dev_priv) ...@@ -6117,6 +6117,9 @@ void intel_enable_ipc(struct drm_i915_private *dev_priv)
{ {
u32 val; u32 val;
if (!HAS_IPC(dev_priv))
return;
/* Display WA #0477 WaDisableIPC: skl */ /* Display WA #0477 WaDisableIPC: skl */
if (IS_SKYLAKE(dev_priv)) if (IS_SKYLAKE(dev_priv))
dev_priv->ipc_enabled = false; dev_priv->ipc_enabled = false;
...@@ -6138,7 +6141,6 @@ void intel_enable_ipc(struct drm_i915_private *dev_priv) ...@@ -6138,7 +6141,6 @@ void intel_enable_ipc(struct drm_i915_private *dev_priv)
void intel_init_ipc(struct drm_i915_private *dev_priv) void intel_init_ipc(struct drm_i915_private *dev_priv)
{ {
dev_priv->ipc_enabled = false;
if (!HAS_IPC(dev_priv)) if (!HAS_IPC(dev_priv))
return; return;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment