Commit fdf0ff4d authored by Dmitry Osipenko's avatar Dmitry Osipenko Committed by Gerd Hoffmann

drm/virtio: Unlock reservations on virtio_gpu_object_shmem_init() error

Unlock reservations in the error code path of virtio_gpu_object_create()
to silence debug warning splat produced by ww_mutex_destroy(&obj->lock)
when GEM is released with the held lock.

Cc: stable@vger.kernel.org
Fixes: 30172efb ("drm/virtio: blob prep: refactor getting pages and attaching backing")
Reviewed-by: default avatarEmil Velikov <emil.l.velikov@gmail.com>
Signed-off-by: default avatarDmitry Osipenko <dmitry.osipenko@collabora.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20220630200726.1884320-4-dmitry.osipenko@collabora.comSigned-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent e473216b
...@@ -249,6 +249,8 @@ int virtio_gpu_object_create(struct virtio_gpu_device *vgdev, ...@@ -249,6 +249,8 @@ int virtio_gpu_object_create(struct virtio_gpu_device *vgdev,
ret = virtio_gpu_object_shmem_init(vgdev, bo, &ents, &nents); ret = virtio_gpu_object_shmem_init(vgdev, bo, &ents, &nents);
if (ret != 0) { if (ret != 0) {
if (fence)
virtio_gpu_array_unlock_resv(objs);
virtio_gpu_array_put_free(objs); virtio_gpu_array_put_free(objs);
virtio_gpu_free_object(&shmem_obj->base); virtio_gpu_free_object(&shmem_obj->base);
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment