Commit fed31a4d authored by Zhouyi Zhou's avatar Zhouyi Zhou Committed by Paul E. McKenney

rcu: Fix macro name CONFIG_TASKS_RCU_TRACE

This commit fixes several typos where CONFIG_TASKS_RCU_TRACE should
instead be CONFIG_TASKS_TRACE_RCU.  Among other things, these typos
could cause CONFIG_TASKS_TRACE_RCU_READ_MB=y kernels to suffer from
memory-ordering bugs that could result in false-positive quiescent
states and too-short grace periods.
Signed-off-by: default avatarZhouyi Zhou <zhouzhouyi@gmail.com>
Signed-off-by: default avatarPaul E. McKenney <paulmck@kernel.org>
parent e4be1f44
...@@ -167,7 +167,7 @@ void synchronize_rcu_tasks(void); ...@@ -167,7 +167,7 @@ void synchronize_rcu_tasks(void);
# define synchronize_rcu_tasks synchronize_rcu # define synchronize_rcu_tasks synchronize_rcu
# endif # endif
# ifdef CONFIG_TASKS_RCU_TRACE # ifdef CONFIG_TASKS_TRACE_RCU
# define rcu_tasks_trace_qs(t) \ # define rcu_tasks_trace_qs(t) \
do { \ do { \
if (!likely(READ_ONCE((t)->trc_reader_checked)) && \ if (!likely(READ_ONCE((t)->trc_reader_checked)) && \
......
...@@ -2982,17 +2982,17 @@ static void noinstr rcu_dynticks_task_exit(void) ...@@ -2982,17 +2982,17 @@ static void noinstr rcu_dynticks_task_exit(void)
/* Turn on heavyweight RCU tasks trace readers on idle/user entry. */ /* Turn on heavyweight RCU tasks trace readers on idle/user entry. */
static void rcu_dynticks_task_trace_enter(void) static void rcu_dynticks_task_trace_enter(void)
{ {
#ifdef CONFIG_TASKS_RCU_TRACE #ifdef CONFIG_TASKS_TRACE_RCU
if (IS_ENABLED(CONFIG_TASKS_TRACE_RCU_READ_MB)) if (IS_ENABLED(CONFIG_TASKS_TRACE_RCU_READ_MB))
current->trc_reader_special.b.need_mb = true; current->trc_reader_special.b.need_mb = true;
#endif /* #ifdef CONFIG_TASKS_RCU_TRACE */ #endif /* #ifdef CONFIG_TASKS_TRACE_RCU */
} }
/* Turn off heavyweight RCU tasks trace readers on idle/user exit. */ /* Turn off heavyweight RCU tasks trace readers on idle/user exit. */
static void rcu_dynticks_task_trace_exit(void) static void rcu_dynticks_task_trace_exit(void)
{ {
#ifdef CONFIG_TASKS_RCU_TRACE #ifdef CONFIG_TASKS_TRACE_RCU
if (IS_ENABLED(CONFIG_TASKS_TRACE_RCU_READ_MB)) if (IS_ENABLED(CONFIG_TASKS_TRACE_RCU_READ_MB))
current->trc_reader_special.b.need_mb = false; current->trc_reader_special.b.need_mb = false;
#endif /* #ifdef CONFIG_TASKS_RCU_TRACE */ #endif /* #ifdef CONFIG_TASKS_TRACE_RCU */
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment