Commit ff57087f authored by shamir rabinovitch's avatar shamir rabinovitch Committed by David S. Miller

rds: debug messages are enabled by default

rds use Kconfig option called "RDS_DEBUG" to enable rds debug messages.
This option cause the rds Makefile to add -DDEBUG to the rds gcc command
line.

When CONFIG_DYNAMIC_DEBUG is enabled, the "DEBUG" macro is used by
include/linux/dynamic_debug.h to decide if dynamic debug prints should
be sent by default to the kernel log.

rds should not enable this macro for production builds. rds dynamic
debug work as expected follow this fix.
Signed-off-by: default avatarShamir Rabinovitch <shamir.rabinovitch@oracle.com>
Acked-by: default avatarSantosh Shilimkar <santosh.shilimkar@oracle.com>
Reviewed-by: default avatarWengang Wang <wen.gang.wang@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 880b583c
......@@ -13,5 +13,5 @@ obj-$(CONFIG_RDS_TCP) += rds_tcp.o
rds_tcp-y := tcp.o tcp_connect.o tcp_listen.o tcp_recv.o \
tcp_send.o tcp_stats.o
ccflags-$(CONFIG_RDS_DEBUG) := -DDEBUG
ccflags-$(CONFIG_RDS_DEBUG) := -DRDS_DEBUG
......@@ -33,7 +33,7 @@
#define KERNEL_HAS_ATOMIC64
#endif
#ifdef DEBUG
#ifdef RDS_DEBUG
#define rdsdebug(fmt, args...) pr_debug("%s(): " fmt, __func__ , ##args)
#else
/* sigh, pr_debug() causes unused variable warnings */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment