Commit ffb81717 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Anna Schumaker

nfs: Fix fall-through warnings for Clang

In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly add multiple break/goto/return/fallthrough
statements instead of just letting the code fall through to the next
case.

Link: https://github.com/KSPP/linux/issues/115Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
parent 93f479d3
...@@ -111,6 +111,7 @@ struct posix_acl *nfs3_get_acl(struct inode *inode, int type) ...@@ -111,6 +111,7 @@ struct posix_acl *nfs3_get_acl(struct inode *inode, int type)
fallthrough; fallthrough;
case -ENOTSUPP: case -ENOTSUPP:
status = -EOPNOTSUPP; status = -EOPNOTSUPP;
goto getout;
default: default:
goto getout; goto getout;
} }
......
...@@ -609,6 +609,7 @@ int nfs40_walk_client_list(struct nfs_client *new, ...@@ -609,6 +609,7 @@ int nfs40_walk_client_list(struct nfs_client *new,
* changed. Schedule recovery! * changed. Schedule recovery!
*/ */
nfs4_schedule_path_down_recovery(pos); nfs4_schedule_path_down_recovery(pos);
goto out;
default: default:
goto out; goto out;
} }
......
...@@ -2227,6 +2227,7 @@ static int nfs4_handle_delegation_recall_error(struct nfs_server *server, struct ...@@ -2227,6 +2227,7 @@ static int nfs4_handle_delegation_recall_error(struct nfs_server *server, struct
default: default:
printk(KERN_ERR "NFS: %s: unhandled error " printk(KERN_ERR "NFS: %s: unhandled error "
"%d.\n", __func__, err); "%d.\n", __func__, err);
fallthrough;
case 0: case 0:
case -ENOENT: case -ENOENT:
case -EAGAIN: case -EAGAIN:
...@@ -9701,6 +9702,7 @@ nfs4_layoutcommit_done(struct rpc_task *task, void *calldata) ...@@ -9701,6 +9702,7 @@ nfs4_layoutcommit_done(struct rpc_task *task, void *calldata)
case -NFS4ERR_BADLAYOUT: /* no layout */ case -NFS4ERR_BADLAYOUT: /* no layout */
case -NFS4ERR_GRACE: /* loca_recalim always false */ case -NFS4ERR_GRACE: /* loca_recalim always false */
task->tk_status = 0; task->tk_status = 0;
break;
case 0: case 0:
break; break;
default: default:
......
...@@ -1125,6 +1125,7 @@ static void nfs_increment_seqid(int status, struct nfs_seqid *seqid) ...@@ -1125,6 +1125,7 @@ static void nfs_increment_seqid(int status, struct nfs_seqid *seqid)
" sequence-id error on an" " sequence-id error on an"
" unconfirmed sequence %p!\n", " unconfirmed sequence %p!\n",
seqid->sequence); seqid->sequence);
return;
case -NFS4ERR_STALE_CLIENTID: case -NFS4ERR_STALE_CLIENTID:
case -NFS4ERR_STALE_STATEID: case -NFS4ERR_STALE_STATEID:
case -NFS4ERR_BAD_STATEID: case -NFS4ERR_BAD_STATEID:
......
...@@ -2875,6 +2875,7 @@ pnfs_do_write(struct nfs_pageio_descriptor *desc, ...@@ -2875,6 +2875,7 @@ pnfs_do_write(struct nfs_pageio_descriptor *desc,
switch (trypnfs) { switch (trypnfs) {
case PNFS_NOT_ATTEMPTED: case PNFS_NOT_ATTEMPTED:
pnfs_write_through_mds(desc, hdr); pnfs_write_through_mds(desc, hdr);
break;
case PNFS_ATTEMPTED: case PNFS_ATTEMPTED:
break; break;
case PNFS_TRY_AGAIN: case PNFS_TRY_AGAIN:
...@@ -3019,6 +3020,7 @@ pnfs_do_read(struct nfs_pageio_descriptor *desc, struct nfs_pgio_header *hdr) ...@@ -3019,6 +3020,7 @@ pnfs_do_read(struct nfs_pageio_descriptor *desc, struct nfs_pgio_header *hdr)
switch (trypnfs) { switch (trypnfs) {
case PNFS_NOT_ATTEMPTED: case PNFS_NOT_ATTEMPTED:
pnfs_read_through_mds(desc, hdr); pnfs_read_through_mds(desc, hdr);
break;
case PNFS_ATTEMPTED: case PNFS_ATTEMPTED:
break; break;
case PNFS_TRY_AGAIN: case PNFS_TRY_AGAIN:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment