Commit ffd603f2 authored by Kuen-Han Tsai's avatar Kuen-Han Tsai Committed by Greg Kroah-Hartman

usb: gadget: u_serial: Add null pointer check in gs_start_io

If gs_close has cleared port->port.tty and gs_start_io is called
afterwards, then the function tty_wakeup will attempt to access the value
of the pointer port->port.tty which will cause a null pointer
dereference error.

To avoid this, add a null pointer check to gs_start_io before attempting
to access the value of the pointer port->port.tty.
Signed-off-by: default avatarKuen-Han Tsai <khtsai@google.com>
Message-ID: <20230602070009.1353946-1-khtsai@google.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0a453dc9
...@@ -539,16 +539,20 @@ static int gs_alloc_requests(struct usb_ep *ep, struct list_head *head, ...@@ -539,16 +539,20 @@ static int gs_alloc_requests(struct usb_ep *ep, struct list_head *head,
static int gs_start_io(struct gs_port *port) static int gs_start_io(struct gs_port *port)
{ {
struct list_head *head = &port->read_pool; struct list_head *head = &port->read_pool;
struct usb_ep *ep = port->port_usb->out; struct usb_ep *ep;
int status; int status;
unsigned started; unsigned started;
if (!port->port_usb || !port->port.tty)
return -EIO;
/* Allocate RX and TX I/O buffers. We can't easily do this much /* Allocate RX and TX I/O buffers. We can't easily do this much
* earlier (with GFP_KERNEL) because the requests are coupled to * earlier (with GFP_KERNEL) because the requests are coupled to
* endpoints, as are the packet sizes we'll be using. Different * endpoints, as are the packet sizes we'll be using. Different
* configurations may use different endpoints with a given port; * configurations may use different endpoints with a given port;
* and high speed vs full speed changes packet sizes too. * and high speed vs full speed changes packet sizes too.
*/ */
ep = port->port_usb->out;
status = gs_alloc_requests(ep, head, gs_read_complete, status = gs_alloc_requests(ep, head, gs_read_complete,
&port->read_allocated); &port->read_allocated);
if (status) if (status)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment