Commit ffeaa23a authored by Junlin Yang's avatar Junlin Yang Committed by Linus Walleij

pinctrl: stm32: add missing of_node_put

Fix OF node leaks by calling of_node_put in
for_each_available_child_of_node when the cycle returns.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci
Signed-off-by: default avatarJunlin Yang <yangjunlin@yulong.com>
Link: https://lore.kernel.org/r/20210215103643.898-1-angkery@163.comAcked-by: default avatarFabien Dessenne <fabien.dessenne@foss.st.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent a7db796b
...@@ -1542,8 +1542,10 @@ int stm32_pctl_probe(struct platform_device *pdev) ...@@ -1542,8 +1542,10 @@ int stm32_pctl_probe(struct platform_device *pdev)
if (of_property_read_bool(child, "gpio-controller")) { if (of_property_read_bool(child, "gpio-controller")) {
bank->rstc = of_reset_control_get_exclusive(child, bank->rstc = of_reset_control_get_exclusive(child,
NULL); NULL);
if (PTR_ERR(bank->rstc) == -EPROBE_DEFER) if (PTR_ERR(bank->rstc) == -EPROBE_DEFER) {
of_node_put(child);
return -EPROBE_DEFER; return -EPROBE_DEFER;
}
bank->clk = of_clk_get_by_name(child, NULL); bank->clk = of_clk_get_by_name(child, NULL);
if (IS_ERR(bank->clk)) { if (IS_ERR(bank->clk)) {
...@@ -1551,6 +1553,7 @@ int stm32_pctl_probe(struct platform_device *pdev) ...@@ -1551,6 +1553,7 @@ int stm32_pctl_probe(struct platform_device *pdev)
dev_err(dev, dev_err(dev,
"failed to get clk (%ld)\n", "failed to get clk (%ld)\n",
PTR_ERR(bank->clk)); PTR_ERR(bank->clk));
of_node_put(child);
return PTR_ERR(bank->clk); return PTR_ERR(bank->clk);
} }
i++; i++;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment