- 17 Oct, 2016 17 commits
-
-
Elizabeth Ferdman authored
Constify the static struct RTW_CHANNEL_PLAN_MAP_REALTEK_DEFINE. The only other instance was one of its properties being assigned to a variable: Index2G = RTW_CHANNEL_PLAN_MAP_REALTEK_DEFINE.Index2G; Therefore this is a good candidate for constification. Running size did not show any difference: Before/After: text data bss dec hex filename 44122 408 2974 47504 b990 Lastly, break up the long line to fix the checkpatch warning and conform to kernel coding style. Signed-off-by:
Elizabeth Ferdman <gnudevliz@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Elise Lennion authored
Simplify return logic to avoid unnecessary variable assignments. Coccinelle was used with this semantic patch: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by:Elise Lennion <elise.lennion@gmail.com> Signed-off-by:
-
Elise Lennion authored
Simplify return logic to avoid unnecessary variable assignments. Coccinelle was used with this semantic patch: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: -
Elise Lennion authored
Compress the return logic into one line avoids unnecessary variable declarations. In this case it also makes it easier to understand the function. Coccinelle was used to find this return statement. However, additional compressions were done to make the function clearer. Semantic patch: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: -
Mihaela Muraru authored
This patch add const qualifier at the declaration of the structure. The structure become a read-only data, this increase the security. Signed-off-by:
Mihaela Muraru <mihaela.muraru21@gmail.com> Signed-off-by:
-
Sabitha George authored
Fixes checkpatch warning: braces{} are not necessary for single statment blocks Signed-off-by:Sabitha George <sabitha.george@gmail.com> Signed-off-by:
-
Sabitha George authored
Fixes checkpatch.pl warning :Missing a blank line after declarations Signed-off-by:
-
Elise Lennion authored
Extern variables and functions used in only one file were removed from .h files, and made static in the .c files they're used. Extern variable wilc_initialized was declared and never used, so it was removed. Signed-off-by:
-
Mihaela Muraru authored
This patch add const qualifier at the declaration of the structure. The structure become a read-only data, this increase the security. Signed-off-by:
-
Laurent Navet authored
this removes lots of sparse warnings : warning: symbol 'visorchannel_destroy' was not declared. Should it be static? warning: symbol 'visorchannel_get_physaddr' was not declared. Should it be static? warning: symbol 'visorchannel_get_nbytes' was not declared. Should it be static? warning: symbol 'visorchannel_uuid_id' was not declared. Should it be static? warning: symbol 'visorchannel_id' was not declared. Should it be static? warning: symbol 'visorchannel_zoneid' was not declared. Should it be static? warning: symbol 'visorchannel_get_clientpartition' was not declared. Should it be static? warning: symbol 'visorchannel_set_clientpartition' was not declared. Should it be static? warning: symbol 'visorchannel_read' was not declared. Should it be static? warning: symbol 'visorchannel_write' was not declared. Should it be static? warning: symbol 'visorchannel_get_header' was not declared. Should it be static? warning: symbol 'visorchannel_create' was not declared. Should it be static? warning: symbol 'visorchannel_create_with_lock' was not declared. Should it be static? Signed-off-by:
Laurent Navet <laurent.navet@gmail.com> Signed-off-by:
-
Mikhail Golubev authored
Function definitions arguments should also have an identifier name as reported by checkpatch.pl. Signed-off-by:
Mikhail Golubev <golubev.mikhail@gmail.com> Signed-off-by:
-
Elise Lennion authored
Const qualifier added to struct declaration to avoid data overwrite during runtime and improve security. Signed-off-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
Elise Lennion authored
Const qualifier added to struct declaration to avoid data overwrite during runtime and improve security. Signed-off-by:
-
Bhumika Goyal authored
The dma_buf_ops structure is stored in the ops field of a dma_buf_export_info structure and also used as a condition inside the if() statement. The if condition does not modify its value and the ops field is of type const struct *dma_buf_ops, so dma_buf_ops structures having this property can be declared as const. File size before: text data bss dec hex filename 14471 819 224 15514 3c9a drivers/staging/android/ion/ion.o File size after: text data bss dec hex filename 14599 707 224 15530 3caa drivers/staging/android/ion/ion.o Signed-off-by:
Bhumika Goyal <bhumirks@gmail.com> Acked-by:
-
Bhumika Goyal authored
Declare tty_port_operations structure as const as it is only stored in the ops field of a tty_port structure which is a field of a gb_tty structure. The ops field is of type const struct tty_port_operations *, so tty_port_operations structures having this property can be declared as const. Done using Coccinelle: @r1 disable optional_qualifier @ identifier i; position p; @@ static struct tty_port_operations i@p = {...}; @ok1@ identifier r1.i; position p; struct gb_tty q; @@ q.port.ops=&i@p @bad@ position p!={r1.p,ok1.p}; identifier r1.i; @@ i@p @depends on !bad disable optional_qualifier@ identifier r1.i; @@ static +const struct tty_port_operations i={...}; @depends on !bad disable optional_qualifier@ identifier r1.i; @@ +const struct tty_port_operations i; File size before: text data bss dec hex filename 7646 512 56 8214 2016 drivers/staging/greybus/uart.o File size after: text data bss dec hex filename 7710 448 56 8214 2016 drivers/staging/greybus/uart.o Signed-off-by:Johan Hovold <johan@kernel.org> Reviewed-by:
David Lin <dtwlin@gmail.com> Acked-by:
-
sayli karnik authored
This patch replaces kmalloc and memcpy with kmemdup for duplication of memory. Signed-off-by:
sayli karnik <karniksayli1995@gmail.com> Signed-off-by:
-
Pankaj Bharadiya authored
gb_audio_manager_module_descriptor's cport field is actually used to manage and pass interface id to user space. Thus rename gb_audio_manager_module_descriptor's 'cport' field and few other things to avoid confusion. Signed-off-by:
Pankaj Bharadiya <pankaj.bharadiya@gmail.com> Reviewed-by:
Vaibhav Agarwal <vaibhav.sr@gmail.com> Acked-by:
Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by:
-
- 16 Oct, 2016 23 commits
-
-
Dan Carpenter authored
This if statement wasn't intended. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Acked-by:
James Simmons <jsimmons@infradead.org> Signed-off-by:
-
Sabitha George authored
Fixes checkpatch.pl warning: do not add new typedefs in ks_wlan_net.c Signed-off-by:
-
Sabitha George authored
Fixes checkpatch.pl warning: __aligned(size) is preferred over __attribute__((aligned(size)) in ks7010_sdio.h Signed-off-by:
-
Elise Lennion authored
Remove function comments that only restate the function name. Signed-off-by:
-
Elise Lennion authored
Replace CamelCase function names with underscores to comply with the standard kernel coding style. Signed-off-by:
-
Elise Lennion authored
Remove return statement that is immediately followed by the function closing bracket. Signed-off-by:
-
Mihaela Muraru authored
Simplify function returns by merging assignment and return into one command line. Delete unnecesarry return variable. Found with Coccinelle @@ expression e, ret; @@ -ret = +return e; -return ret Signed-off-by: -
Mihaela Muraru authored
Simplify function returns by merging assignment and return into one command line. Found with Coccinelle @@ expression e, ret; @@ -ret = +return e; -return ret; Signed-off-by: -
Mihaela Muraru authored
Simplify function returns by merging assignment and return into one command line. Found with Coccinelle @@ expression e, ret; @@ -ret = +return e; -return ret; Signed-off-by: -
Varsha Rao authored
This patch removes the macros BBvClearFOE and BBvSetFOE. As they are not used anywhere else. Signed-off-by:
Varsha Rao <rvarsha016@gmail.com> Signed-off-by:
-
Varsha Rao authored
This patch fixes the checkpatch issue by adding space around '<<'. Signed-off-by:
-
Varsha Rao authored
This patch fixes the checkpatch issue by adding space around the operator '+'. Signed-off-by:
-
Mikhail Golubev authored
Block comments should align the * on each line as reported by checkpatch.pl Signed-off-by:
-
Alexander Alemayhu authored
Fixes the following checkpatch output: ./pcbit/capi.c:39: WARNING: Use #include <linux/io.h> instead of <asm/io.h> ./pcbit/capi.c:40: WARNING: Use #include <linux/string.h> instead of <asm/string.h> ./pcbit/callbacks.c:25: WARNING: Use #include <linux/io.h> instead of <asm/io.h> ./pcbit/layer2.c:39: WARNING: Use #include <linux/io.h> instead of <asm/io.h> ./pcbit/drv.c:34: WARNING: Use #include <linux/string.h> instead of <asm/string.h> ./pcbit/drv.c:35: WARNING: Use #include <linux/io.h> instead of <asm/io.h> ./pcbit/edss1.c:26: WARNING: Use #include <linux/io.h> instead of <asm/io.h> Signed-off-by:
Alexander Alemayhu <alexander@alemayhu.com> Signed-off-by:
-
Chase Metzger authored
Removed a checkpatch warning for braces on single argument if and else statement. Signed-off-by:
Chase Metzger <chasemetzger15@gmail.com> Acked-by:
-
Elise Lennion authored
Fix checkpatch warning: WARNING: Block comments use a trailing */ on a separate line Signed-off-by:
-
Elise Lennion authored
Fix checkpatch warning: WARNING: Prefer kcalloc over kzalloc with multiply kcalloc is designed to allocate memory for arrays, its use is preferable than kzalloc in these cases. Signed-off-by:
-
Elise Lennion authored
Fix checkpatch warning: WARNING: Statements should start on a tabstop Signed-off-by:
-
Elise Lennion authored
Fix checkpatch warning: WARNING: Missing a blank line after declarations Signed-off-by:
-
Wayne Porter authored
Line goes too long when aligned with parenthesis, so moved to a new line Signed-off-by:
Wayne Porter <wporter82@gmail.com> Signed-off-by:
-
Wayne Porter authored
Fix lines that go over 80 characters to stop warnings from checkpatch Signed-off-by:
-
Wayne Porter authored
Move comments above long definitions so they don't go over 80 characters Signed-off-by:
-
Wayne Porter authored
Aligning with parenthesis causes lines to go too long, so the parenthesis are on a new line Signed-off-by:
-
