- 05 Jul, 2011 40 commits
-
-
Ondrej Zary authored
Don't crash with NULL pointer dereference on load because of empty .name. Signed-off-by:
Ondrej Zary <linux@rainbow-software.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Kirill Smelkov authored
As described above fillin_formats() """ /* * THE 16-BIT easycap_format.mask HAS MEANING: * (least significant) BIT 0: 0 => PAL, 25 FPS; 1 => NTSC, 30 FPS * BITS 2-4: RESERVED FOR DIFFERENTIATING STANDARDS * BITS 5-7: NUMBER OF BYTES PER PIXEL * BIT 8: 0 => NATIVE BYTE ORDER; 1 => SWAPPED * BITS 9-10: RESERVED FOR OTHER BYTE PERMUTATIONS * BIT 11: 0 => UNDECIMATED; 1 => DECIMATED * BIT 12: 0 => OFFER FRAMES; 1 => OFFER FIELDS * BIT 13: 0 => FULL FRAMERATE; 1 => REDUCED * (most significant) BITS 14-15: RESERVED FOR OTHER FIELD/FRAME OPTIONS * IT FOLLOWS THAT: * bytesperpixel IS ((0x00E0 & easycap_format.mask) >> 5) * byteswaporder IS true IF (0 != (0x0100 & easycap_format.mask)) * * decimatepixel IS true IF (0 != (0x0800 & easycap_format.mask)) * * offerfields IS true IF (0 != (0x1000 & easycap_format.mask)) */ """ bytes-per-pixel is stored in bits 5-7 of calculated mask. But when calculating bytes-per-line we were extracting wrong value instead of bytes-per-pixel, which was usually 2 times bigger -- e.g. for PAL YUV 422 I was getting ((mask3 & 0x00F0) >> 4) = 4 bytes instead of 2. The error here is that even in comments there is a line saying * bytesperpixel IS ((0x00E0 & easycap_format.mask) >> 5) but we were using ((0x00F0 & easycap_format.mask) >> 4) With 2 times bigger bytesperpixel and automatically bytesperline, the video was shown halfheight'ed, which is understandable if we look at video-memory layout: <------- bytesperline --------> <- real bpl -> x0----------y0 x1-----------y1 x2----------y2 x3-----------y3 xn----------yn xn-----------yn <garbage> for each line, we should display width pixels, then move to next line with bytesperline, and oops, if bytesperline = 2*real-bytesperlin, we'll skip one line and move to next-next line, and so only half lines will be shown. Initially I've debugged the problem with my video application[1], but I've checked that after this patch both rawv (mine app) and tvtime work correctly. [1] http://repo.or.cz/w/rawv.git P.S. why at all we use those mask/shifts? Why not use bitfields? Cc: Mike Thomas <rmthomas@sciolus.org> Signed-off-by:Kirill Smelkov <kirr@mns.spb.ru> Acked-by:
Tomas Winkler <tomas.winkler@intel.com> Signed-off-by:
-
Kirill Smelkov authored
I'm not 100% sure, only 99.99% that PAGE_SIZE is always defined in Linux. So there is no need to check for it. Cc: Mike Thomas <rmthomas@sciolus.org> Signed-off-by:
-
Kirill Smelkov authored
Because V4L1 was completly removed from the kernel in 2.6.38. See e.g. 08af245d ([media] V4L: remove V4L1 compatibility mode). Cc: Mike Thomas <rmthomas@sciolus.org> Signed-off-by:
-
Kirill Smelkov authored
Both bars=0 and bars=1 were described as meaning to display bars on signal lost. Actually bars=1 means "display bars", but bars=0 means display raw source as is (usually black screen). Instead of changing bars=0 to "_no_ testcard bars ..." as suggested by Dan Carpenter reword the whole bars description for clarity. Cc: Mike Thomas <rmthomas@sciolus.org> Cc: Dan Carpenter <error27@gmail.com> Signed-off-by:
-
Kirill Smelkov authored
The following options were removed from in-tree driver, but were left in README: - EASYCAP_IS_VIDEODEV_CLIENT was removed in cb81fa07 (staging/easycap: kill EASYCAP_IS_VIDEODEV_CLIENT compilation conditional); - EASYCAP_NEEDS_V4L2_DEVICE_H/EASYCAP_NEEDS_V4L2_FOPS were removed in 30516058 (staging/easycap: kill EASYCAP_NEEDS_V4L2_DEVICE_H and EASYCAP_NEEDS_V4L2_FOPS); - EASYCAP_NEEDS_UNLOCKED_IOCTL was removed in f2b3c685 (staging/easycap: kill EASYCAP_NEEDS_UNLOCKED_IOCTL). Remove them. Cc: Mike Thomas <rmthomas@sciolus.org> Signed-off-by:
-
Michael Fiedler authored
Fixes scripts/checkpatch.pl warning. Signed-off-by:
Michael Fiedler <michael.fiedler@informatik.stud.uni-erlangen.de> Acked-by:
Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by:
-
Michael Fiedler authored
Fixes warning from scripts/checkpatch.pl. Signed-off-by:
-
Michael Fiedler authored
According to scripts/checkpatch.pl, the __packed macro from linux/compiler.h should be used. Signed-off-by:
-
Michael Fiedler authored
There is already a macro defined in linux/compiler.h. Signed-off-by:
-
Dan Carpenter authored
The JOM() macro dereferences peasycap, so I moved the free down some lines. Signed-off-by:
Dan Carpenter <error27@gmail.com> Acked-by:
-
Tobias Klauser authored
This fixes out-of-tree builds ($builddir != $srcdir). In such cases, libusbip.la cannot be found because it is generated in the build directory and not the source directory. Signed-off-by:
Tobias Klauser <tklauser@distanz.ch> Acked-by:
matt mooney <mfm@muteddisk.com> Signed-off-by:
-
Zac Storer authored
Fixed a brace coding style warning. Signed-off-by:
Zac Storer <zac.3.14159@gmail.com> Signed-off-by:
-
Larry Finger authored
There are two devices with PCI ID 0x10ec:0x8192, namely RTL8192E and RTL8192SE. The method of distinguishing them is by the revision ID at offset 0x8 of the PCI configuration space. If the value is 0x10, then the device uses rtl8192se for a driver. Signed-off-by:
-
Wanlong Gao authored
Remove the use of obsolete create_workqueue(name, 0) interface in ieee80211_softmac.c, since it has changed. Signed-off-by:
Wanlong Gao <wanlong.gao@gmail.com> Signed-off-by:
-
Wanlong Gao authored
Remove the use of obsolete create_workqueue(name, 0) interface in r8192U_core.c, since it has changed. Signed-off-by:
-
Wanlong Gao authored
Remove the use of obsolete create_workqueue(name, 0) in ieee80211_softmac.c, since the create_workqueue interface has changed. Signed-off-by:
-
Joe Perches authored
Just tyops. Signed-off-by:
Joe Perches <joe@perches.com> Signed-off-by:
-
Tobias Klauser authored
Same text as for the config ALTERA_STAPL entry, so remove it. Signed-off-by:
-
Jerome Marchand authored
Currently, nothing protects zram table from concurrent access. For instance, ZRAM_UNCOMPRESSED bit can be cleared by zram_free_page() called from a concurrent write between the time ZRAM_UNCOMPRESSED has been set and the time it is tested to unmap KM_USER0 in zram_bvec_write(). This ultimately leads to kernel panic. Also, a read request can occurs when the page has been freed by a running write request and before it has been updated, leading to zero filled block being incorrectly read and "Read before write" error message. This patch replace the current mutex by a rw_semaphore. It extends the protection to zram table (currently, only compression buffers are protected) and read requests (currently, only write requests are protected). Signed-off-by:
Jerome Marchand <jmarchan@redhat.com> Signed-off-by:
-
Jerome Marchand authored
Commit 7b19b8d4 (zram: Prevent overflow in logical block size) introduced ZRAM_LOGICAL_BLOCK_SIZE constant to prevent overflow of logical block size on 64k page kernel. However, the current implementation of zram only allow operation on block of the same size as a page. That makes theorically legit 4k requests fail on 64k page kernel. This patch makes zram allow operation on partial pages. Basically, it means we still do operations on full pages internally, but only copy the relevent segments from/to the user memory. Signed-off-by:
-
Jerome Marchand authored
This patch refactor the code of zram_read/write() functions. It does not removes a lot of duplicate code alone, but is mostly a helper for the third patch of this series (Staging: zram: allow partial page operations). Signed-off-by:
-
Jerome Marchand authored
The offset of uncompressed page is always zero: handle_uncompressed_page() doesn't have to care about it. Signed-off-by:
-
Roland Vossen authored
Code cleanup. Replaced Broadcom proprietary error codes with Linux native ones. Signed-off-by:
Roland Vossen <rvossen@broadcom.com> Reviewed-by:
Arend van Spriel <arend@broadcom.com> Reviewed-by:
Franky Lin <frankyl@broadcom.com> Signed-off-by:
-
Henry Ptasinski authored
Updated TODO file to reflect current driver state, results of recent cleanup and fixes. Signed-off-by:
Henry Ptasinski <henryp@broadcom.com> Signed-off-by:
-
Roland Vossen authored
Every few minutes, this message would appear in syslog: ieee80211 ph0: wl_ops_bss_info_changed: BSS idle: true (implement) The message has been deleted, the driver requires no special action on this particular event (). See: https://bugzilla.kernel.org/show_bug.cgi?id=38162Reported-by:
David Hill <hilld@binarystorm.net> Signed-off-by:
-
Arend van Spriel authored
The static functions in wl_cfg80211.c starting with wl_ prefix have been renamed starting with brcmf_ prefix to be consistent. Signed-off-by:
-
Arend van Spriel authored
cleanup of some unused macros. Signed-off-by:
-
Roland Vossen authored
Code cleanup. Signed-off-by:
-
Roland Vossen authored
Code cleanup. Function declarations were moved to .h files. Signed-off-by:
-
Arend van Spriel authored
The structure dhd_pub has been renamed to have more consistent naming in the fullmac driver. This also remove the type definition for this structure. Signed-off-by:
-
Arend van Spriel authored
renamed structures to consitent naming convention and removed the structure type definitions. Signed-off-by:
-
Arend van Spriel authored
structure have been renamed for consistency and the structure typedefs have been removed. Signed-off-by:
-
Arend van Spriel authored
Several unused macro definitions have been removed. Signed-off-by:
-
Arend van Spriel authored
The definitions in dhd.h have been renamed with consistent prefix BRCMF_. Signed-off-by:
-
Arend van Spriel authored
Structure definitions in dhd.h have been prefixed with brcmf_ for consistent naming in fullmac driver and typedef of these structures has been removed. Signed-off-by:
-
Arend van Spriel authored
Several defintions from dhd.h are not used in the fullmac driver and have been removed. Signed-off-by:
-
Arend van Spriel authored
The fullmac driver uses dhd as variable name for the driver instance in a number of functions. This has been changed to a more generic name as the dhd is not meaningful (broadcom internal name). Signed-off-by:
-
Franky Lin authored
In brcmfmac the firmware download related code scatter all around. And some old dead code which is not following the standard firmware routine is still present. This patch limits the firmware download related code only in dhd_sdio.c and removes the rest. Signed-off-by:
-
Franky Lin authored
In fullmac the lock is for race condition for sdio interface. Move the code to dhd_sdio.c Signed-off-by:
-
