- 23 Jul, 2024 40 commits
-
-
Ryan Seto authored
[Why] Visual confirm was incorrect on dual monitor SubVP setup [How] Adjusted p_state assignment for dual monitor SubVP setup Signed-off-by:
Ryan Seto <ryanseto@amd.com> Reviewed-by:
Chaitanya Dhere <chaitanya.dhere@amd.com> Signed-off-by:
Aurabindo Pillai <aurabindo.pillai@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Hansen Dsouza authored
[why & how] Add standard RCG helpers based on DCCG spec Reviewed-by:
Daniel Miess <daniel.miess@amd.com> Reviewed-by:
Muhammad Ahmed <ahmed.ahmed@amd.com> Signed-off-by:
Hansen Dsouza <hansen.dsouza@amd.com> Signed-off-by:
-
Rodrigo Siqueira authored
In the DML math_ceil2 function, there is one ASSERT if the significance is equal to zero. However, significance might be equal to zero sometimes, and this is not an issue for a ceil function, but the current ASSERT will trigger warnings in those cases. This commit removes the ASSERT if the significance is equal to zero to avoid unnecessary noise. Cc: Mario Limonciello <mario.limonciello@amd.com> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: stable@vger.kernel.org Reviewed-by:
Rodrigo Siqueira <rodrigo.siqueira@amd.com> Signed-off-by:
-
Revalla Hari Krishna authored
[Why] To refactor HPO files [How] Moved hpo related files to specific hpo folder and update Makefiles. Reviewed-by:
Martin Leung <martin.leung@amd.com> Signed-off-by:
Revalla Hari Krishna <harikrishna.revalla@amd.com> Signed-off-by:
-
Hansen Dsouza authored
[why & how] Add private data types for better RCG control Reviewed-by:
Chris Park <chris.park@amd.com> Reviewed-by:
Yihan Zhu <yihan.zhu@amd.com> Signed-off-by:
-
Sung Joon Kim authored
[why & how] Need to make sure plane_state is initialized before accessing its members. Cc: Mario Limonciello <mario.limonciello@amd.com> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: stable@vger.kernel.org Reviewed-by:
Xi (Alex) Liu <xi.liu@amd.com> Signed-off-by:
Sung Joon Kim <sungjoon.kim@amd.com> Signed-off-by:
-
Dillon Varone authored
[WHY&HOW] Hardmax message will be retired for dcn4, so this removes it. Reviewed-by:
Alvin Lee <alvin.lee2@amd.com> Signed-off-by:
Dillon Varone <dillon.varone@amd.com> Signed-off-by:
-
Philip Yang authored
Add helper function kfd_queue_acquire_buffers to get queue wptr_bo reference from queue write_ptr if it is mapped to the KFD node with expected size. Add wptr_bo to structure queue_properties because structure queue is allocated after queue buffers are validated, then we can remove wptr_bo parameter from pqm_create_queue. Rename structure queue wptr_bo_gart to hold wptr_bo reference for GART mapping and umapping. Move MES wptr_bo_gart mapping to init_user_queue, the same location with queue ctx_bo GART mapping. Signed-off-by:
Philip Yang <Philip.Yang@amd.com> Reviewed-by:
Felix Kuehling <felix.kuehling@amd.com> Acked-by:
Christian König <christian.koenig@amd.com> Signed-off-by:
-
Sunil Khatri authored
Add ip dump for sdma_v4_4_2 for devcoredump for all instances of sdma. Reviewed-by:
Sunil Khatri <sunil.khatri@amd.com> Signed-off-by:
-
Sunil Khatri authored
Add print support for ip dump for sdma_v_4_0 in devcoredump. Reviewed-by:
-
Philip Yang authored
Pass pointer reference to amdgpu_bo_unref to clear the correct pointer, otherwise amdgpu_bo_unref clear the local variable, the original pointer not set to NULL, this could cause use-after-free bug. Signed-off-by:
-
Philip Yang authored
Change amdgpu_amdkfd_bo_mapped_to_dev to use drm_priv as parameter instead of adev, to support spatial partition. This is only used by CRIU checkpoint restore now. No functional change. Signed-off-by:
-
Jane Jian authored
For VCN/JPEG 4.0.3, use only the local addressing scheme. - Mask bit higher than AID0 range v2 remain the case for mmhub use master XCC Signed-off-by:
Jane Jian <Jane.Jian@amd.com> Reviewed-by:
Lijo Lazar <lijo.lazar@amd.com> Signed-off-by:
-
Lijo Lazar authored
VCN 4.0.3 does not HDP flush with RRMT enabled. Instead, mmsch will do the HDP flush. This change is necessary for VCN v4.0.3, no need for backward compatibility Signed-off-by:
Hawking Zhang <Hawking.Zhang@amd.com> Signed-off-by:
-
Lijo Lazar authored
JPEG v4.0.3 doesn't support HDP flush when RRMT is enabled. Instead, mmsch fw will do the flush. This change is necessary for JPEG v4.0.3, no need for backward compatibility Signed-off-by:
-
Pierre-Eric Pelloux-Prayer authored
Before this commit, only submits with both a BO_HANDLES chunk and a 'bo_list_handle' would be rejected (by amdgpu_cs_parser_bos). But if UMD sent multiple BO_HANDLES, what would happen is: * only the last one would be really used * all the others would leak memory as amdgpu_cs_p1_bo_handles would overwrite the previous p->bo_list value This commit rejects submissions with multiple BO_HANDLES chunks to match the implementation of the parser. Signed-off-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Reviewed-by:
-
Sunil Khatri authored
Add ip dump for sdma_v4_0 for devcoredump for all instances of sdma. Reviewed-by:
-
Sunil Khatri authored
Add print support for ip dump for sdma_v_7_0 in devcoredump. Reviewed-by:
-
Ma Ke authored
Return 0 to avoid returning an uninitialized variable r. Cc: stable@vger.kernel.org Fixes: 230dd6bb ("drm/amd/amdgpu: implement mode2 reset on smu_v13_0_10") Signed-off-by:
Ma Ke <make24@iscas.ac.cn> Signed-off-by:
-
Ma Ke authored
In amdgpu_connector_add_common_modes(), the return value of drm_cvt_mode() is assigned to mode, which will lead to a NULL pointer dereference on failure of drm_cvt_mode(). Add a check to avoid npd. Cc: stable@vger.kernel.org Fixes: d38ceaf9 ("drm/amdgpu: add core driver (v4)") Signed-off-by:
-
David Belanger authored
If PCIe supports atomics, configure register to prevent DF from breaking atomics in separate load/store operations. Signed-off-by:
David Belanger <david.belanger@amd.com> Reviewed-by:
-
Sunil Khatri authored
Add ip dump for sdma_v7_0 for devcoredump for all instances of sdma. Reviewed-by:
-
Alex Deucher authored
We seem to have a case where SDMA will sometimes miss a doorbell if GFX is entering the powergating state when the doorbell comes in. To workaround this, we can update the wptr via MMIO, however, this is only safe because we disallow gfxoff in begin_ring() for SDMA 5.2 and then allow it again in end_ring(). Enable this workaround while we are root causing the issue with the HW team. Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/3440Tested-by:
Friedrich Vock <friedrich.vock@gmx.de> Signed-off-by:
-
Srinivasan Shanmugam authored
Fixes the below with gcc W=1: Function parameter or struct member 'pstate_keepout' not described in 'optc1_program_timing' Cc: Tom Chung <chiahsuan.chung@amd.com> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> Cc: Roman Li <roman.li@amd.com> Cc: Alex Hung <alex.hung@amd.com> Cc: Aurabindo Pillai <aurabindo.pillai@amd.com> Cc: Harry Wentland <harry.wentland@amd.com> Cc: Hamza Mahfooz <hamza.mahfooz@amd.com> Signed-off-by:
Srinivasan Shanmugam <srinivasan.shanmugam@amd.com> Reviewed-by:
Tom Chung <chiahsuan.chung@amd.com> Signed-off-by:
-
Ma Ke authored
In radeon_add_common_modes(), the return value of drm_cvt_mode() is assigned to mode, which will lead to a possible NULL pointer dereference on failure of drm_cvt_mode(). Add a check to avoid npd. Cc: stable@vger.kernel.org Fixes: d50ba256 ("drm/kms: start adding command line interface using fb.") Signed-off-by:
-
YiPeng Chai authored
Remove unused code. Signed-off-by:
YiPeng Chai <YiPeng.Chai@amd.com> Reviewed-by:
-
YiPeng Chai authored
1. Use pa_pfn as the radix-tree key index to log deferred error info. 2. Use local array to store a row of bad pages. Signed-off-by:
-
YiPeng Chai authored
Split into 3 parts: 1. Convert soc physical address via ras ta. 2. Expand bad pages from soc physical address. 3. Dump bad address info. Signed-off-by:
-
Wu Hoi Pok authored
"drm_dev_alloc" is deprecated, in order to use the newer "devm_drm_dev_alloc", the "drm_device" is stored inside "radeon_device", by changing "rdev_to_drm(rdev)" other functions still gain access to the member "drm_device". Also, "devm_drm_dev_alloc" is now allocating "radeon_device", allocation inside "radeon_driver_load_kms" has to be removed. In "radeon_device_init", it originally assigned "rdev->dev" etc. However it is already done right after "devm_drm_dev_alloc" as you can see down below. It is better remove them. Reviewed-by:
Thomas Zimmermann <tzimmermann@suse.de> Tested-by:
Wu Hoi Pok <wuhoipok@gmail.com> Signed-off-by:
-
Wu Hoi Pok authored
This patch changes the way "drm_device" is accessed. It uses "rdev_to_drm(rdev)" instead of accessing the struct member directly. Reviewed-by:
-
Wu Hoi Pok authored
Add helper rdev_to_drm(rdev), similar to amdgpu, most function should access the "drm_device" with "rdev_to_drm(rdev)" instead, where amdgpu has "adev_to_drm(adev)". It also makes changing from "*drm_device" to "drm_device" in "radeon_devicce" later on easier. Reviewed-by:
-
Wu Hoi Pok authored
To be consistent with amdgpu driver, use "flags" as the parameter because it is already assigned as "ent->driver_data". Reviewed-by:
-
Wu Hoi Pok authored
The ".load" callback in "struct drm_driver" is deprecated. In order to remove the callback, we have to manually call "radeon_driver_load_kms" instead. Acked-by:
-
Wu Hoi Pok authored
In the probe function of amdgpu, it uses "ddev" as the name of "struct drm_device *", so I suggest renaming it to be consistent. Reviewed-by:
-
Aric Cyr authored
* FW Release 0.0.225.0 * DML2 fixes * Allow display DCC for DCN401 * Refactor DWB, OPP, MPC, MMHUBBUB * Fix dscclk Programming issue on DCN401 Acked-by:
Jerry Zuo <jerry.zuo@amd.com> Signed-off-by:
Aric Cyr <aric.cyr@amd.com> Tested-by:
Daniel Wheeler <daniel.wheeler@amd.com> Signed-off-by:
-
Rodrigo Siqueira authored
Acked-by:
-
Joshua Aberback authored
[Why] In some cases during topology changes, a pipe that was used to drive a stream being removed can be re-assigned to drive a different stream. In these cases, DSC power gating is not handled properly, leading to situations where DSC is being setup while power gated. [How] - remove enable_stream_gating and disable_stream_gating for DCN401 Reviewed-by:
Wenjing Liu <wenjing.liu@amd.com> Signed-off-by:
Joshua Aberback <joshua.aberback@amd.com> Tested-by:
-
Aurabindo Pillai authored
fix a memleak introduced by not removing the buffer object for use with early dmub bounding box value storage Fixes: 234e9455 ("drm/amd/display: Enable copying of bounding box data from VBIOS DMUB") Reviewed-by:
Alex Hung <alex.hung@amd.com> Signed-off-by:
-
Duncan Ma authored
[Why] Visual Confirm would tell us if it ever entered idle state. [How] Add debug option for IPS visual confirm Reviewed-by:
Ovidiu Bunea <ovidiu.bunea@amd.com> Signed-off-by:
Duncan Ma <duncan.ma@amd.com> Tested-by:
-
Daniel Sa authored
why: When the cursor disappears/reappears on fullscreen video, there is a short transitional period where the cursor's color matrix is using the same format as the video plane. This sets the cursor to the wrong color momentarily before the UI plane appears, correcting the color. how: Instead of defaulting to using the color space from the input plane, default to bypass mode. Reviewed-by:
Nevenko Stupar <nevenko.stupar@amd.com> Signed-off-by:
Daniel Sa <daniel.sa@amd.com> Tested-by:
-
