1. 06 May, 2020 7 commits
  2. 05 May, 2020 30 commits
  3. 04 May, 2020 3 commits
    • David S. Miller's avatar
      Merge branch 'net-reduce-dynamic-lockdep-keys' · 354d8614
      David S. Miller authored
      Cong Wang says:
      
      ====================
      net: reduce dynamic lockdep keys
      
      syzbot has been complaining about low MAX_LOCKDEP_KEYS for a
      long time, it is mostly because we register 4 dynamic keys per
      network device.
      
      This patchset reduces the number of dynamic lockdep keys from
      4 to 1 per netdev, by reverting to the previous static keys,
      except for addr_list_lock which still has to be dynamic.
      The second patch removes a bonding-specific key by the way.
      ====================
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      354d8614
    • Cong Wang's avatar
      bonding: remove useless stats_lock_key · e7511f56
      Cong Wang authored
      After commit b3e80d44
      ("bonding: fix lockdep warning in bond_get_stats()") the dynamic
      key is no longer necessary, as we compute nest level at run-time.
      So, we can just remove it to save some lockdep key entries.
      
      Test commands:
       ip link add bond0 type bond
       ip link add bond1 type bond
       ip link set bond0 master bond1
       ip link set bond0 nomaster
       ip link set bond1 master bond0
      
      Reported-and-tested-by: syzbot+aaa6fa4949cc5d9b7b25@syzkaller.appspotmail.com
      Cc: Dmitry Vyukov <dvyukov@google.com>
      Acked-by: default avatarTaehee Yoo <ap420073@gmail.com>
      Signed-off-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      e7511f56
    • Cong Wang's avatar
      net: partially revert dynamic lockdep key changes · 1a33e10e
      Cong Wang authored
      This patch reverts the folowing commits:
      
      commit 064ff66e
      "bonding: add missing netdev_update_lockdep_key()"
      
      commit 53d37497
      "net: avoid updating qdisc_xmit_lock_key in netdev_update_lockdep_key()"
      
      commit 1f26c0d3
      "net: fix kernel-doc warning in <linux/netdevice.h>"
      
      commit ab92d68f
      "net: core: add generic lockdep keys"
      
      but keeps the addr_list_lock_key because we still lock
      addr_list_lock nestedly on stack devices, unlikely xmit_lock
      this is safe because we don't take addr_list_lock on any fast
      path.
      
      Reported-and-tested-by: syzbot+aaa6fa4949cc5d9b7b25@syzkaller.appspotmail.com
      Cc: Dmitry Vyukov <dvyukov@google.com>
      Cc: Taehee Yoo <ap420073@gmail.com>
      Signed-off-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
      Acked-by: default avatarTaehee Yoo <ap420073@gmail.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      1a33e10e