- 18 Feb, 2022 18 commits
-
-
Mordechay Goodstein authored
Our HE capable HW also supports DCM mode, so broadcast this capability in the HE PHY capabilities. Signed-off-by:
Mordechay Goodstein <mordechay.goodstein@intel.com> Signed-off-by:
Luca Coelho <luciano.coelho@intel.com> Link: https://lore.kernel.org/r/iwlwifi.20220129105618.f7f1b31a8c75.Id349f61dfd9d3514c08ad0917b1607d35ab73dfa@changeidSigned-off-by:
-
Mordechay Goodstein authored
Currently we enable DCM if the peer supports RX without checking whether we advertised that we support TX. Fix this by also checking that our TX side is set. Signed-off-by:
-
Rotem Saado authored
DBGI SRAM is new type of monitor, therefore it should be dump as monitor type with ini dump monitor header. Signed-off-by:
Rotem Saado <rotem.saado@intel.com> Fixes: 89639e06 ("iwlwifi: yoyo: support for new DBGI_SRAM region") Signed-off-by:
-
Mordechay Goodstein authored
Until now function just got a pointer to some buffer and used it as if it's good to use with no boundaries about size left in the buffer. This infra helps for internal functions ops to make sure buffer usage is in bound of allocation. We also add external checks with warnings to verify every internal function didn't exceed usage of the free buffer size. Signed-off-by:
-
Emmanuel Grumbach authored
Those devices have more BAIDs, which is the hardware module that tracks the BA session. Signed-off-by:
Emmanuel Grumbach <emmanuel.grumbach@intel.com> Signed-off-by:
-
Johannes Berg authored
Due to some rearchitecting inside the firmware, a new BAID allocation command is being introduced. Support it. Note that with it the firmware no longer returns "no space" but will crash instead, so check for that before sending the command to the firmware. Signed-off-by:
Johannes Berg <johannes.berg@intel.com> Signed-off-by:
-
Johannes Berg authored
Refactor the firmware call in iwl_mvm_sta_rx_agg() out into its own function to be able to change it more easily in the next patch. Signed-off-by:
-
Mordechay Goodstein authored
In order to support 1K aggregations start ba queue with at least double the size, also allocate based on the connecting type to save memory usage. Signed-off-by:
-
Johannes Berg authored
Avoid void pointer arithmetic since it's technically undefined and causes warnings in some places that use our code. Signed-off-by:
-
Johannes Berg authored
When enabling W=3 that gets us -Wcast-qual, fix those warnings in the code and propagate constness properly, or cast it away via (uintptr_t) where really needed. Signed-off-by:
-
Bjoern A. Zeeb authored
Most of this change is a continuation of commit 403ea939 ("iwlwifi: dbg: Mark ucode tlv data as const") propagating the (const) type qualifier for ucode based tlv data to avoid having the impression that it is writeable. The other part of the change preserves the (const) type qualifier over casts and function calls where it was previously lost. Both changes are needed to avoid compile time errors on system with more strict error settings, in this case found with clang on FreeBSD. Sponsored by: The FreeBSD Foundation Signed-off-by:
Bjoern A. Zeeb <bz@FreeBSD.ORG> Signed-off-by:
-
Bjoern A. Zeeb authored
In order to de-const variables simply casting through (void *) is not enough: "cast from 'const .. *' to 'void *' drops const qualifier". Cast through (uintptr_t) as well [1] to make this compile on systems with more strict requirements. In addition passing const void *data to dma_map_single() also drops the (const) qualifier. De-constify on variable on assignment which may be overwritten later. In either case the (void *) cast to dma_map_single() is not needed (anymore) either. [1] See __DECONST() in sys/sys/cdefs.h in FreeBSD Sponsored by: The FreeBSD Foundation Signed-off-by:
-
Johannes Berg authored
Instead of taking the group/command separately, make the function take a combined command ID. In many cases, this allows us to pass an existing command ID (e.g. cmd.id), or introduce a new variable for it, so that we don't use the command ID twice. This way, we can also use LONG_GROUP implicitly, so we don't need to spell that out for many commands. Apart from mvm.h, fw/img.{c,h} changes and some copyright and indentation updates, this was done with spatch: @@ identifier cmd; expression fw, G, C, def; @@ struct iwl_host_cmd cmd = { .id = WIDE_ID(G, C), ... }; ... -iwl_fw_lookup_cmd_ver(fw, G, C, def) +iwl_fw_lookup_cmd_ver(fw, cmd.id, def) @@ identifier cmd; expression fw, C, def; @@ struct iwl_host_cmd cmd = { .id = C, ... }; ... -iwl_fw_lookup_cmd_ver(fw, \(IWL_ALWAYS_LONG_GROUP\|LONG_GROUP\), C, def) +iwl_fw_lookup_cmd_ver(fw, cmd.id, def) @@ identifier func; expression fw, G, C, mvm, flags, cmd, size, def; type rettype; @@ rettype func(...) { +u32 cmd_id = WIDE_ID(G, C); ... -iwl_fw_lookup_cmd_ver(fw, G, C, def) +iwl_fw_lookup_cmd_ver(fw, cmd_id, def) ... -iwl_mvm_send_cmd_pdu(mvm, WIDE_ID(G, C), flags, cmd, size) +iwl_mvm_send_cmd_pdu(mvm, cmd_id, flags, cmd, size) ... } @@ identifier func; expression fw, G, C, mvm, flags, cmd, size, def; type rettype; @@ rettype func(...) { +u32 cmd_id = C; ... -iwl_fw_lookup_cmd_ver(fw, \(IWL_ALWAYS_LONG_GROUP\|LONG_GROUP\), C, def) +iwl_fw_lookup_cmd_ver(fw, cmd_id, def) ... -iwl_mvm_send_cmd_pdu(mvm, C, flags, cmd, size) +iwl_mvm_send_cmd_pdu(mvm, cmd_id, flags, cmd, size) ... } @@ expression fw, C, def; @@ -iwl_fw_lookup_cmd_ver(fw, \(IWL_ALWAYS_LONG_GROUP\|LONG_GROUP\), C, def) +iwl_fw_lookup_cmd_ver(fw, C, def) @@ expression fw, C, G, def; @@ -iwl_fw_lookup_cmd_ver(fw, G, C, def) +iwl_fw_lookup_cmd_ver(fw, WIDE_ID(G, C), def) Signed-off-by: -
Johannes Berg authored
This is valid, but pretty uncommon in the driver, clean up the code here a bit to use an initializer. Signed-off-by:
-
Johannes Berg authored
The order of arguments for iwl_cmd_id() is confusing, and the version is always 0 and thus a useless argument. Prefer the WIDE_ID() macro (which needs to be a macro due to use in switch cases etc.) over the iwl_cmd_id() function. Obviously done with spatch: @@ expression G, C; @@ -iwl_cmd_id(C, G, 0) +WIDE_ID(G, C) Signed-off-by:
-
Ayala Barazani authored
Read a new bit defined in ACPI WTAS that allows OEMs to specify whether TAS is allowed in UHB (6-7GHz) in the USA. This can be used by OEMs that got certified to use this feature. Signed-off-by:
Ayala Barazani <ayala.barazani@intel.com> Signed-off-by:
-
Nathan Errera authored
Since FW is now in charge of timing the channel switch, there is no need to send the add/modify/remove time event command to fw with every (e)CSA element. However, the driver needs to cancel the channel switch if the CS start notification arrives and it does not know about an ongoing channel switch. Signed-off-by:
Nathan Errera <nathan.errera@intel.com> Signed-off-by:
-
Takashi Iwai authored
The recent fix for NULL sta in iwl_mvm_get_tx_rate() still has a call of iwl_mvm_sta_from_mac80211() that may be called with NULL sta. Although this practically only points to the address and the actual access doesn't happen due to the conditional evaluation at a later point, it looks a bit flaky. This patch drops the temporary variable above and evaluates iwm_mvm_sta_from_mac80211() directly for avoiding confusions. Fixes: d599f714 ("iwlwifi: mvm: don't crash on invalid rate w/o STA") Signed-off-by:
Takashi Iwai <tiwai@suse.de> Link: https://lore.kernel.org/r/20220121114024.10454-1-tiwai@suse.deSigned-off-by:
-
- 16 Feb, 2022 22 commits
-
-
Ilan Peer authored
Add EHT capabilities to bands. Signed-off-by:
Ilan Peer <ilan.peer@intel.com> Link: https://lore.kernel.org/r/20220214173004.1b710f8e04ce.I11d6911dafc01deb8ceb7828e363e8554701790a@changeidSigned-off-by:
-
Mordechay Goodstein authored
In EHT requesting aggregation with 1K needs the use of extended the AddBA element for the buffer size, so add the logic to parse it and make sure it's in limits of the EHT aggregation size. Signed-off-by:
-
Mordechay Goodstein authored
If the station supports EHT mode, calculate the maximum RX NSS from EHT station capabilities. Signed-off-by:
-
Ilan Peer authored
When a station configuration is updated, also update the station EHT capabilities. Signed-off-by:
-
Ilan Peer authored
When the association is an EHT association, parse the EHT element from the association response and update the station's EHT capabilities accordingly. Signed-off-by:
-
Ilan Peer authored
Add the EHT capabilities element to both probe request and association request frames, if advertised by the driver. Signed-off-by:
-
Ilan Peer authored
Add initial support for EHT and 320 MHz bandwidth in mac80211. As a new IEEE80211_STA_RX_BW_320 is added to enum ieee80211_sta_rx_bandwidth, update the drivers to avoid compilation warnings. Signed-off-by:
-
Ilan Peer authored
Parse the new EHT elements in the element parsing utilities. Signed-off-by:
-
Ilan Peer authored
Add attributes and some code bits to support userspace passing in EHT capabilities of stations. Signed-off-by:
-
Ilan Peer authored
This may be necessary in some cases, add a flag and propagate it, just like the NO-HE that already exists. Signed-off-by:
-
Sriram R authored
Add support to advertise drivers or regulatory limitations on 320 MHz channels to userspace. Signed-off-by:
Sriram R <quic_srirrama@quicinc.com> Co-authored-by:
Karthikeyan Periyasamy <quic_periyasia@quicinc.com> Signed-off-by:
Veerendranath Jakkam <quic_vjakkam@quicinc.com> Signed-off-by:
-
Veerendranath Jakkam authored
Add support for reporting and calculating EHT bitrates. Signed-off-by:
-
Jia Ding authored
Add 320 MHz support in the channel def and center frequency validation with compatible check. Signed-off-by:
Jia Ding <quic_jiad@quicinc.com> Co-authored-by:
Karthikeyan Periyasamy <quic_periyasa@quicinc.com> Signed-off-by:
Muna Sinada <quic_msinada@quicinc.com> Signed-off-by:
-
Ilan Peer authored
And advertise EHT capabilities to user space when supported. Signed-off-by:
-
Mordechay Goodstein authored
We add the fields for parsing extended ADDBA request/respond, and new max 1K aggregation for limit ADDBA request/respond. Adjust drivers to use the proper macro, IEEE80211_MAX_AMPDU_BUF -> IEEE80211_MAX_AMPDU_BUF_HE. Signed-off-by:
-
Ilan Peer authored
Based on Draft P802.11be_D1.4. Signed-off-by:
-
Ilan Peer authored
Add a custom regulatory domain for testing 6 GHz, including 320 MHz bandwidth. This can be used before the regulatory databases are all updated etc. Signed-off-by:
-
Johannes Berg authored
The argument to hwsim_init_s1g_channels() shadows a global, change that to be clearer. Link: https://lore.kernel.org/r/20220214173004.66bac90d64a8.I3e878e42bf2feecbb0a6ca38a68c236c23a8c9e6@changeidSigned-off-by:
-
Johannes Berg authored
Add checks to hwsim to validate that neither TX nor any station's configured bandwidth can exceed the channel (context) configuration previously requested. Link: https://lore.kernel.org/r/20220214173004.9fd154d2c3c2.Ia0cd152357a373149bab017d479ab7d5ded289c0@changeidSigned-off-by:
-
Johannes Berg authored
The kernel (driver code) should be able to assume that a station's HE capabilities are not badly sized, so reject them if they are. Link: https://lore.kernel.org/r/20220214172921.80b710d45cb7.Id57ce32f9538a40e36c620fabedbd2c73346ef56@changeidSigned-off-by:
-
Johannes Berg authored
The code validates the HE capability element size later, but slightly wrong, so use the new helper to do it right and only accept it if it has a good size. Link: https://lore.kernel.org/r/20220214172920.b5b06f264a61.I645ac1e2dc0ace223ef3e551cd5a71c88bd55e04@changeidSigned-off-by:
-
Johannes Berg authored
This element has a very dynamic structure, create a small helper function to validate its size. We're currently checking it in mac80211 in a conversion function, but that's actually slightly buggy. Link: https://lore.kernel.org/r/20220214172920.750bee9eaf37.Ie18359bd38143b7dc949078f10752413e6d36854@changeidSigned-off-by:
-
